From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQe6g-0005Sc-Dg for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:38:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQe6a-0000te-CC for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:38:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQe6a-0000rs-54 for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:38:00 -0400 Message-ID: <532AFD42.7030602@redhat.com> Date: Thu, 20 Mar 2014 15:37:54 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1395324392-2142-1-git-send-email-stefanha@redhat.com> <1395324392-2142-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1395324392-2142-3-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0 2/2] dataplane: replace iothread object_add() with embedded instance List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Christian Borntraeger Il 20/03/2014 15:06, Stefan Hajnoczi ha scritto: > + object_initialize(&s->internal_iothread_obj, > + sizeof(s->internal_iothread_obj), > + TYPE_IOTHREAD); > + user_creatable_complete(OBJECT(&s->internal_iothread_obj), &error_abort); Perhaps you need an object_property_add_child here? Otherwise the link points to an object without a canonical path. Can do it as a follow-up though. Paolo