From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQeKq-0008C7-Ct for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:52:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQeKh-0006Hd-7r for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:52:44 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:60771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQeKg-0006HH-Uc for qemu-devel@nongnu.org; Thu, 20 Mar 2014 10:52:35 -0400 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 20 Mar 2014 14:52:33 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id AF7BA1B08051 for ; Thu, 20 Mar 2014 14:52:21 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s2KEqJRF000350 for ; Thu, 20 Mar 2014 14:52:19 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s2KEqU6K015579 for ; Thu, 20 Mar 2014 08:52:30 -0600 Message-ID: <532B00AD.3000002@de.ibm.com> Date: Thu, 20 Mar 2014 15:52:29 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1395324392-2142-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1395324392-2142-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0 0/2] dataplane: fix internal IOThread name collision List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini On 20/03/14 15:06, Stefan Hajnoczi wrote: > Christian Borntraeger noticed that the naming of the > internal IOThread objects, which are created when the user does not specify an > IOThread explicitly, can result in collisions. > > These patches make the IOThread object nameless so it cannot cause collisions. > This is important when multiple dataplane devices are used simultaneously or > the user happened to choose a colliding name. > > Stefan Hajnoczi (2): > iothread: make IOThread struct definition public > dataplane: replace iothread object_add() with embedded instance > > hw/block/dataplane/virtio-blk.c | 31 ++++++++++++------------------- > include/sysemu/iothread.h | 12 +++++++++++- > iothread.c | 11 ----------- > 3 files changed, 23 insertions(+), 31 deletions(-) > This seem to make my setup functional again. Tested-by: Christian Borntraeger Thanks