From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQftb-0005a7-Vr for qemu-devel@nongnu.org; Thu, 20 Mar 2014 12:32:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQftX-0001XF-3C for qemu-devel@nongnu.org; Thu, 20 Mar 2014 12:32:43 -0400 Message-ID: <532B180F.5080301@redhat.com> Date: Thu, 20 Mar 2014 17:32:15 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20140227011300.8CD451983B@mono.eik.bme.hu> <532B0C5D.5060905@msgid.tls.msk.ru> <532B0E71.1000009@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan Cc: qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org Il 20/03/2014 17:01, BALATON Zoltan ha scritto: > On Thu, 20 Mar 2014, Paolo Bonzini wrote: >> Il 20/03/2014 16:42, Michael Tokarev ha scritto: >>> 10.03.2014 22:40, BALATON Zoltan wrote: >>>> Ping! >>>> http://patchwork.ozlabs.org/patch/324674/ >>> >>> Thanks, applied to -trivial. >> >> No, please don't; this needs to be done for new machine types only. > > Why? I tried running a Windows XP image that was set up before this > patch and it did not complain about changed hardware. Or is there > another reason I'm missing? Classes (or anything guest-visible in fact) must never ever be changed for the same machine type. It's a rule. Paolo