From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQieQ-000491-DS for qemu-devel@nongnu.org; Thu, 20 Mar 2014 15:29:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQieM-0005y2-2Q for qemu-devel@nongnu.org; Thu, 20 Mar 2014 15:29:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQieL-0005xy-R8 for qemu-devel@nongnu.org; Thu, 20 Mar 2014 15:29:10 -0400 Message-ID: <532B416C.7040500@redhat.com> Date: Thu, 20 Mar 2014 13:28:44 -0600 From: Eric Blake MIME-Version: 1.0 References: <1395145464-5524-1-git-send-email-arei.gonglei@huawei.com> <1395145464-5524-4-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1395145464-5524-4-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a8qMRQ4eb2RojDHJHV0JM1CGofhwuh5Ah" Subject: Re: [Qemu-devel] [PATCH v3 03/10] migration: expose the bitmap_sync_counter to the end user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: ChenLiang , owasserm@redhat.com, pbonzini@redhat.com, weidong.huang@huawei.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --a8qMRQ4eb2RojDHJHV0JM1CGofhwuh5Ah Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/18/2014 06:24 AM, arei.gonglei@huawei.com wrote: > From: ChenLiang >=20 > expose the counter that log the times of updating the dirty bitmap to s/log/logs/ > end user. >=20 > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > arch_init.c | 1 + > hmp.c | 2 ++ > include/migration/migration.h | 1 + > migration.c | 2 ++ > qapi-schema.json | 4 +++- > qmp-commands.hx | 13 +++++++++---- > 6 files changed, 18 insertions(+), 5 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -651,13 +651,15 @@ > # > # @mbps: throughput in megabits/sec. (since 1.6) > # > +# @dirty-sync-counter: the times of ram dirty sync (since 2.1) The name could possibly be shortened. Also, this sentence reads awkwardly. Maybe: @dirty-sync-count: number of times that dirty ram was synchronized (since 2.1) > +++ b/qmp-commands.hx > @@ -2928,6 +2928,7 @@ The main json-object contains the following: > pages. This is just normal pages times size of one page, > but this way upper levels don't need to care about page > size (json-int) > + - "dirty-sync-counter": the times of ram dirty sync (json-int= ) and if you do change the wording above (or even shorten the variable name), make it match here --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --a8qMRQ4eb2RojDHJHV0JM1CGofhwuh5Ah Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTK0FsAAoJEKeha0olJ0NqyPgH/jgiMMVNP9UfwTlrgfvWQlKc veHvHXw1fc3fPla4yGW+l56qLWjn5fzSsd5AtmuL8LBxpWI4qjNWCjFJP/kql+sL HJGbkw0FTl558haaFtU9UEs3E9MI1X3w5AU59SMMxYOBQHRDZ7S+3m39QOfOCz3f cOMJQfvrR3KQpszgrz3TamUNQBXFcdvtoCSekxXpl0YST0ey7iNUPbSGeQsLG1+J PL3AwbwUx0WgzrYMgsCKmJAHcJ6i/beIkfJa5YEejY9BLCSDcQuhn3NpwC3JJLoY YkpGMsj6NY9IwTcACxXfZjtyHMb8qHnqORw0y9e7aiDZOBgX0AXF2/PVfyui1Lw= =C7HS -----END PGP SIGNATURE----- --a8qMRQ4eb2RojDHJHV0JM1CGofhwuh5Ah--