From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQisA-0006wW-3x for qemu-devel@nongnu.org; Thu, 20 Mar 2014 15:43:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQis5-0001z1-Hw for qemu-devel@nongnu.org; Thu, 20 Mar 2014 15:43:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQis5-0001ys-9c for qemu-devel@nongnu.org; Thu, 20 Mar 2014 15:43:21 -0400 Message-ID: <532B44D2.30704@redhat.com> Date: Thu, 20 Mar 2014 13:43:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <1395145464-5524-1-git-send-email-arei.gonglei@huawei.com> <1395145464-5524-6-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1395145464-5524-6-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7hSpj9QiV7gmPoW7UAp9ff6hWsSfQRlQP" Subject: Re: [Qemu-devel] [PATCH v3 05/10] XBZRLE: optimize XBZRLE to decrease the cache missing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: ChenLiang , owasserm@redhat.com, pbonzini@redhat.com, weidong.huang@huawei.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7hSpj9QiV7gmPoW7UAp9ff6hWsSfQRlQP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/18/2014 06:24 AM, arei.gonglei@huawei.com wrote: > From: ChenLiang In the subject: s/missing/misses/ >=20 > Avoid hot pages being replaced by others to remarkably decrease cache s/cache/cache misses/ >=20 > before this patch: > virsh qemu-monitor-command test_vm '{"execute": "query-migrate"}' > {"return":{"expected-downtime":1020,"xbzrle-cache":{"bytes":1108284, 1.1M bytes saved by compression, > "cache-size":8388608,"cache-miss-rate":0.987013,"pages":18297,"overflow= ":8, 18k pages sent compressed > "cache-miss":1228737},"status":"active","setup-time":10,"total-time":52= 398, > "ram":{"total":12466991104,"remaining":1695744,"mbps":935.559472, > "transferred":5780760580,"dirty-sync-counter":271,"duplicate":2878530, > "dirty-pages-rate":29130,"skipped":0,"normal-bytes":5748592640, > "normal":1403465}},"id":"libvirt-706"} >=20 > cache-miss-rate is 98.7%, totally miss. >=20 > after optimizing: > virsh qemu-monitor-command test_vm '{"execute": "query-migrate"}' > {"return":{"expected-downtime":2054,"xbzrle-cache":{"bytes":5066763, 5.0M bytes saved by compression > "cache-size":8388608,"cache-miss-rate":0.485924,"pages":194823,"overflo= w":0, 194k pages sent compressed > "cache-miss":210653},"status":"active","setup-time":11,"total-time":187= 29, And reduced from 52 milleseconds to just under 19 on total time. Definite improvements! > "ram":{"total":12466991104,"remaining":3895296,"mbps":937.663549, > "transferred":1615042219,"dirty-sync-counter":98,"duplicate":2869840, > "dirty-pages-rate":58781,"skipped":0,"normal-bytes":1588404224, > "normal":387794}},"id":"libvirt-266"} >=20 > The value of cache-miss-rate decrease 49.13%. s/decrease/decreased to/ >=20 > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > arch_init.c | 8 +++++--- > include/migration/page_cache.h | 10 +++++++--- > page_cache.c | 23 +++++++++++++++++++---- > 3 files changed, 31 insertions(+), 10 deletions(-) >=20 Reviewed-by: Eric Blake However, I think it would be worth squashing patch 10 into this one. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7hSpj9QiV7gmPoW7UAp9ff6hWsSfQRlQP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTK0TSAAoJEKeha0olJ0Nq1jEIAIg3fLxmFqv8CpHGlrh1dneZ QHRyMF5nQ5ClJnEkIoaxRsw6gP6ljxrUnQ09KxueMC86nGD6gQov/EBKRxhbd3Dn /sr7VtPIN/Qhya6GzaTh0Eqeheb/OkSnbFfnKzPqQ9P/hWVafSyj2OQJJHHqSTOg a/DECAB+FUmzMISAJLAxxjAoqE+RZ8Xvmf0KV8IT49cR3oYX6Jy/auxW4xoA4dVe NthuGQIJmZy18eypNH4OKrfv10bY4l+Yw4bPJko+0M1Jub6gLIRreQXIMw4A9HrE dccTYzySqpOXysshJCCcUoQ+WmzIFKPs0Pcit80pYXHq3PVN+p5yC2jshBQHIMA= =+hVC -----END PGP SIGNATURE----- --7hSpj9QiV7gmPoW7UAp9ff6hWsSfQRlQP--