From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQj53-0008S7-VS for qemu-devel@nongnu.org; Thu, 20 Mar 2014 15:56:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQj4z-00069u-Fy for qemu-devel@nongnu.org; Thu, 20 Mar 2014 15:56:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQj4z-00069p-78 for qemu-devel@nongnu.org; Thu, 20 Mar 2014 15:56:41 -0400 Message-ID: <532B47F1.1030103@redhat.com> Date: Thu, 20 Mar 2014 13:56:33 -0600 From: Eric Blake MIME-Version: 1.0 References: <1395145464-5524-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1395145464-5524-1-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H7hIXi8U8VqltXxh7loMdKBB0o5LMoMIK" Subject: Re: [Qemu-devel] [PATCH v3 00/10] migration: Optimizate the xbzrle and fix two corruption issues List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: ChenLiang , owasserm@redhat.com, pbonzini@redhat.com, weidong.huang@huawei.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --H7hIXi8U8VqltXxh7loMdKBB0o5LMoMIK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/18/2014 06:24 AM, arei.gonglei@huawei.com wrote: > From: ChenLiang >=20 > V2-->V3 > * rename the bitmap_sync_cnt to bitmap_sync_counter > * expose xbzrle cache miss rate >=20 > V1-->V2 > * expose the counter that logs the times of updating the dirty bitmap t= o end user. >=20 > a. Optimization the xbzrle remarkable decrease the cache misses. > The efficiency of compress increases more than fifty times. > Before the patch set, the cache almost totally miss when the=20 > number of cache item less than the dirty page number. Now the > hot pages in the cache will not be replaced by other pages.=20 >=20 > b. Reducing the data copy >=20 > c. Fix two corruption issues. Your QAPI changes were marked 2.1, but this series also includes a corruption fix. Please split this series into patches that MUST be applied for 2.0 as bug fixes, vs. the patches that are a feature enhancement (or else with strong justification why a speed optimization is safe enough to be considered a bug fix, if you think the whole series belongs in 2.0). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --H7hIXi8U8VqltXxh7loMdKBB0o5LMoMIK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTK0fxAAoJEKeha0olJ0NqneIH/2zKMwYFmwNWNmEG26/KSpip mlQ1jYzGRPBKNtkZZ4T1sJSyOaUTaTKqF8lPocOUtZo7QWGhRIoFrLlcwBeF/ssq jRu6KvjBPp220dewjAp9pNzgu7MyydCBgMUXRKvrhrnXLJO1EEOq18JZFRurps26 i3dtSSrEh2jyRU/DXZ59Z0JyzU8tUUwdyyEgvJmyHgYlK5FRwOQJ3Q0yxAOMT15F PLQ3GjQ3rvgIvJdKHIxmcO+2Zp5NLEtm5vtgrVR2Zl83awBRrE/IkWuabS43KvBu Lmkg9lHOq+6c3cVrWxR51VGof0PzbAKUDaXQL7k/u/3dLZ96ZGZDKw0bHxxWi6I= =+h6H -----END PGP SIGNATURE----- --H7hIXi8U8VqltXxh7loMdKBB0o5LMoMIK--