From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQk25-0007Gq-6t for qemu-devel@nongnu.org; Thu, 20 Mar 2014 16:57:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQk20-0001ua-TW for qemu-devel@nongnu.org; Thu, 20 Mar 2014 16:57:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQk20-0001uU-Km for qemu-devel@nongnu.org; Thu, 20 Mar 2014 16:57:40 -0400 Message-ID: <532B563F.7090007@redhat.com> Date: Thu, 20 Mar 2014 14:57:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1395320855-5293-1-git-send-email-akong@redhat.com> In-Reply-To: <1395320855-5293-1-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Rmw4KdLiJLxKcR8p5wI5XQ2QWgmnFs1x6" Subject: Re: [Qemu-devel] [PATCH v3 for 2.0] update names in option tables to match with actual command-line spelling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, afaerber@suse.de, libvirt-list@redhat.com, anthony@codemonkey.ws, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Rmw4KdLiJLxKcR8p5wI5XQ2QWgmnFs1x6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/20/2014 07:07 AM, Amos Kong wrote: > We want to establish a mapping between option name and option table, > then we can search related option table by option name. >=20 > This patch makes all the member name of QemuOptsList to match with > actual command-line spelling(option name). >=20 > [ Important Note ] >=20 > The QemuOptsList member name values are ABI, changing them can break > existing -readconfig configuration files. >=20 > This patch changes: >=20 > from to introduced in > acpi acpitable 0c764a9 v1.5.0 > boot-opts boot 3d3b830 v1.0 > smp-opts smp 12b7f57 v1.6.0 >=20 > All three have calcified into ABI already. >=20 > I have updated the release note of 2.0 > http://wiki.qemu.org/ChangeLog/2.0#ABI_breaking >=20 > Signed-off-by: Amos Kong > --- The benefit of this patch is that 'query-command-line-options' gains a fix where three bogus entries are replaced by their actual command line spelling. The drawback is that anyone that doesn't pay attention to the ABI break announcement, and expects -readconfig and friends to work while using the old spelling, is in for a surprise. But since we have prominently documented the change, and since consistency makes life nicer, I'm in favor of this patch. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Rmw4KdLiJLxKcR8p5wI5XQ2QWgmnFs1x6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTK1Y/AAoJEKeha0olJ0NqskIH/RIXoKXVO4/q61M86vLjLAVm jPGKeBnj38pGkIBtGAaDD5zJBv9Utn9ycLntnx/657+V+fHINRe333lCQVfS4yWV 5crwx+vh73szVHZzOCDGupgAMSAOBZiT1lybTJs72HuyTbkEClbI1W38JNLqXtpt EwGpn0mbMTUdMACLD4oURK6p06Hn/IoPCYfMHxCufb7qivbKbem3T1g9BimrUnJs H2xvBnJNPofxUjVpWyQv5VPM05ArYucj7osCfx1vR4/Bd9m82k5gMIGMGIDgQeK7 FFEDIgPijV4S4Z13Q8j9OLt5HjWKU9nItP7pSmF0OJRH3TAbzbc0Wn/c/mIShcU= =oKr2 -----END PGP SIGNATURE----- --Rmw4KdLiJLxKcR8p5wI5XQ2QWgmnFs1x6--