From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.a@redhat.com>
Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH for-2.0 V2] tests/acpi-test: do not run iasl on big endian machines
Date: Thu, 20 Mar 2014 22:57:13 +0100 [thread overview]
Message-ID: <532B6439.5080302@redhat.com> (raw)
In-Reply-To: <20140320201611.GA2884@redhat.com>
Il 20/03/2014 21:16, Michael S. Tsirkin ha scritto:
> Seems too aggressive: can't we detect the broken iasl?
> E.g. won't it fail to disassemble expected AML files?
Yes.
> Also, won't this broken iasl generate corrupt AML
> on output? If yes we should detect this at configure
> time instead?
No, the output is fine. There are patches from Debian (that I updated
and applied to Fedora last year) that take care of fixing endianness on
output, but no such patches for the disassembly.
On one hand, I'm fine with not running IASL at all on big-endian
machines. On the other hand, it will certainly cause the patches to bitrot.
Paolo
prev parent reply other threads:[~2014-03-20 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 18:40 [Qemu-devel] [PATCH for-2.0 V2] tests/acpi-test: do not run iasl on big endian machines Marcel Apfelbaum
2014-03-20 20:16 ` Michael S. Tsirkin
2014-03-20 21:57 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532B6439.5080302@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aik@ozlabs.ru \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).