From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQkxr-0005kf-6Z for qemu-devel@nongnu.org; Thu, 20 Mar 2014 17:57:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQkxi-0005dm-Ih for qemu-devel@nongnu.org; Thu, 20 Mar 2014 17:57:27 -0400 Received: from mail-qc0-x22f.google.com ([2607:f8b0:400d:c01::22f]:37512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQkxi-0005di-Dw for qemu-devel@nongnu.org; Thu, 20 Mar 2014 17:57:18 -0400 Received: by mail-qc0-f175.google.com with SMTP id e16so1837349qcx.20 for ; Thu, 20 Mar 2014 14:57:17 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <532B6439.5080302@redhat.com> Date: Thu, 20 Mar 2014 22:57:13 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1395340808-21352-1-git-send-email-marcel.a@redhat.com> <20140320201611.GA2884@redhat.com> In-Reply-To: <20140320201611.GA2884@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0 V2] tests/acpi-test: do not run iasl on big endian machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Marcel Apfelbaum Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, afaerber@suse.de Il 20/03/2014 21:16, Michael S. Tsirkin ha scritto: > Seems too aggressive: can't we detect the broken iasl? > E.g. won't it fail to disassemble expected AML files? Yes. > Also, won't this broken iasl generate corrupt AML > on output? If yes we should detect this at configure > time instead? No, the output is fine. There are patches from Debian (that I updated and applied to Fedora last year) that take care of fixing endianness on output, but no such patches for the disassembly. On one hand, I'm fine with not running IASL at all on big-endian machines. On the other hand, it will certainly cause the patches to bitrot. Paolo