From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQmCy-0000al-Vc for qemu-devel@nongnu.org; Thu, 20 Mar 2014 19:17:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQmCq-00077E-II for qemu-devel@nongnu.org; Thu, 20 Mar 2014 19:17:08 -0400 Received: from mail-qc0-x22b.google.com ([2607:f8b0:400d:c01::22b]:50797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQmCq-00076u-Do for qemu-devel@nongnu.org; Thu, 20 Mar 2014 19:17:00 -0400 Received: by mail-qc0-f171.google.com with SMTP id c9so1954342qcz.16 for ; Thu, 20 Mar 2014 16:17:00 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <532B76E5.7090608@redhat.com> Date: Fri, 21 Mar 2014 00:16:53 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1395350099-14664-1-git-send-email-marcel.a@redhat.com> <532B645B.5020507@redhat.com> <1395353214.21800.6.camel@localhost.localdomain> <532B6B27.2080105@redhat.com> <1395354837.21800.12.camel@localhost.localdomain> In-Reply-To: <1395354837.21800.12.camel@localhost.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , Laszlo Ersek Cc: peter.maydell@linaro.org, mst@redhat.com, aik@ozlabs.ru, mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com, afaerber@suse.de, rth@twiddle.net Il 20/03/2014 23:33, Marcel Apfelbaum ha scritto: > I've seen something like that somewhere, but I didn't quite like it. > I was looking for something more elegant as I was *almost* sure > this kind of solution will not pass the reviews :) > > But maybe I'll try this, let's see what happens, If all you're looking for is bigendian (disabling iasl disassembly on bigendian makes sense), your patch v2 is fine. Assembling ASL on bigendian is supported by at least Fedora and Debian (and hence Ubuntu). Paolo