From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34101)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1WQtBX-000069-WF
	for qemu-devel@nongnu.org; Fri, 21 Mar 2014 02:44:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1WQtBR-0003TF-MZ
	for qemu-devel@nongnu.org; Fri, 21 Mar 2014 02:44:07 -0400
Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:47798 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1WQtBR-0003S2-Bg
	for qemu-devel@nongnu.org; Fri, 21 Mar 2014 02:44:01 -0400
Message-ID: <532BDFA0.7050807@kamp.de>
Date: Fri, 21 Mar 2014 07:43:44 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1395360813-2833-1-git-send-email-l@dorileo.org>
	<1395360813-2833-10-git-send-email-l@dorileo.org>
In-Reply-To: <1395360813-2833-10-git-send-email-l@dorileo.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 09/26] iscsi: migrate iscsi driver
 QemuOptionParameter usage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Leandro Dorileo <l@dorileo.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Liu Yuan <namei.unix@gmail.com>, Jeff Cody <jcody@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Richard W.M. Jones" <rjones@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Ronnie Sahlberg <ronniesahlberg@gmail.com>, Josh Durgin <josh.durgin@inktank.com>, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Weil <sw@weilnetz.de>, Max Reitz <mreitz@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, Benoit Canet <benoit@irqsave.net>

On 21.03.2014 01:13, Leandro Dorileo wrote:
> Do the directly migration from QemuOptionParameter to QemuOpts on
> iscsi block driver.
>
> Signed-off-by: Leandro Dorileo <l@dorileo.org>
> ---
>   block/iscsi.c | 32 ++++++++++++++++----------------
>   1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index b490e98..85252e7 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1125,7 +1125,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
>       QemuOpts *opts;
>       Error *local_err = NULL;
>       const char *filename;
> -    int i, ret;
> +    int i, ret = 0;

why? is there a chance that ret remains uninitialized?

>   
>       if ((BDRV_SECTOR_SIZE % 512) != 0) {
>           error_setg(errp, "iSCSI: Invalid BDRV_SECTOR_SIZE. "
> @@ -1382,8 +1382,7 @@ static int iscsi_truncate(BlockDriverState *bs, int64_t offset)
>       return 0;
>   }
>   
> -static int iscsi_create(const char *filename, QEMUOptionParameter *options,
> -                        Error **errp)
> +static int iscsi_create(const char *filename, QemuOpts *options, Error **errp)
>   {
>       int ret = 0;
>       int64_t total_size = 0;
> @@ -1393,12 +1392,9 @@ static int iscsi_create(const char *filename, QEMUOptionParameter *options,
>   
>       bs = bdrv_new("");
>   
> -    /* Read out options */
> -    while (options && options->name) {
> -        if (!strcmp(options->name, "size")) {
> -            total_size = options->value.n / BDRV_SECTOR_SIZE;
> -        }
> -        options++;
> +    total_size = qemu_opt_get_size(options, BLOCK_OPT_SIZE, 0);
> +    if (total_size) {
> +        total_size = total_size / BDRV_SECTOR_SIZE;
>       }
you don't need the if condition. 0 / BDRV_SECTOR_SIZE = 0.

Peter
>   
>       bs->opaque = g_malloc0(sizeof(struct IscsiLun));
> @@ -1451,13 +1447,17 @@ static int iscsi_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
>       return 0;
>   }
>   
> -static QEMUOptionParameter iscsi_create_options[] = {
> -    {
> -        .name = BLOCK_OPT_SIZE,
> -        .type = OPT_SIZE,
> -        .help = "Virtual disk size"
> +static QemuOptsList iscsi_create_options = {
> +    .name = "iscsi_create_options",
> +    .head = QTAILQ_HEAD_INITIALIZER(iscsi_create_options.head),
> +    .desc = {
> +        {
> +            .name = BLOCK_OPT_SIZE,
> +            .type = QEMU_OPT_SIZE,
> +            .help = "Virtual disk size"
> +        },
> +        { NULL }
>       },
> -    { NULL }
>   };
>   
>   static BlockDriver bdrv_iscsi = {
> @@ -1469,7 +1469,7 @@ static BlockDriver bdrv_iscsi = {
>       .bdrv_file_open  = iscsi_open,
>       .bdrv_close      = iscsi_close,
>       .bdrv_create     = iscsi_create,
> -    .create_options  = iscsi_create_options,
> +    .create_options  = &iscsi_create_options,
>       .bdrv_reopen_prepare  = iscsi_reopen_prepare,
>   
>       .bdrv_getlength  = iscsi_getlength,


-- 

Mit freundlichen Grüßen

Peter Lieven

...........................................................

   KAMP Netzwerkdienste GmbH
   Vestische Str. 89-91 | 46117 Oberhausen
   Tel: +49 (0) 208.89 402-50 | Fax: +49 (0) 208.89 402-40
   pl@kamp.de | http://www.kamp.de

   Geschäftsführer: Heiner Lante | Michael Lante
   Amtsgericht Duisburg | HRB Nr. 12154
   USt-Id-Nr.: DE 120607556

...........................................................