From: Richard Henderson <rth@twiddle.net>
To: Olivier Danet <odanet@caramail.com>,
qemu-devel <qemu-devel@nongnu.org>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow
Date: Fri, 21 Mar 2014 08:23:08 -0700 [thread overview]
Message-ID: <532C595C.4070605@twiddle.net> (raw)
In-Reply-To: <532B94FF.4090809@caramail.com>
On 03/20/2014 06:25 PM, Olivier Danet wrote:
> The signed integer division -0x8000_0000_0000_0000 / -1 must be handled
> separately to avoid an overflow on the QEMU host.
>
> Negative overflow must be a negative number for correct sign
> extension in Sparc64 mode. Use <stdint.h> constants.
>
> Signed-off-by: Olivier Danet <odanet@caramail.com>
> ---
> target-sparc/helper.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2014-03-21 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 1:25 [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow Olivier Danet
2014-03-21 7:07 ` Mark Cave-Ayland
2014-03-21 15:23 ` Richard Henderson
2014-03-21 15:23 ` Richard Henderson [this message]
2014-03-24 21:07 ` Mark Cave-Ayland
2014-03-24 21:36 ` Peter Maydell
2014-03-24 22:43 ` Andreas Färber
2014-03-26 15:03 ` Mark Cave-Ayland
2014-03-26 15:20 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C595C.4070605@twiddle.net \
--to=rth@twiddle.net \
--cc=blauwirbel@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=odanet@caramail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).