From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WR1Id-0000Ym-5W for qemu-devel@nongnu.org; Fri, 21 Mar 2014 11:24:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WR1IT-0004OW-9C for qemu-devel@nongnu.org; Fri, 21 Mar 2014 11:23:59 -0400 Received: from mail-qg0-x232.google.com ([2607:f8b0:400d:c04::232]:63707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WR1IT-0004OK-5Q for qemu-devel@nongnu.org; Fri, 21 Mar 2014 11:23:49 -0400 Received: by mail-qg0-f50.google.com with SMTP id q108so7450951qgd.9 for ; Fri, 21 Mar 2014 08:23:48 -0700 (PDT) Sender: Richard Henderson Message-ID: <532C5981.4040406@twiddle.net> Date: Fri, 21 Mar 2014 08:23:45 -0700 From: Richard Henderson MIME-Version: 1.0 References: <532B94FF.4090809@caramail.com> <532BE51E.7060208@ilande.co.uk> In-Reply-To: <532BE51E.7060208@ilande.co.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , Olivier Danet Cc: Blue Swirl , qemu-devel On 03/21/2014 12:07 AM, Mark Cave-Ayland wrote: > > This basic patch looks good to me. My only comment is that I suspect for > bisection purposes it may be better to split this into 2 patches - one to > perform the conversion of all existing constants to INT*_MAX and INT*_MIN, and > then a second to add your change to prevent the crash. I'll let Richard have > the final say though. I think one patch is fine. r~