From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
Igor Mammedov <imammedo@redhat.com>,
qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages
Date: Fri, 21 Mar 2014 16:49:05 +0100 [thread overview]
Message-ID: <532C5F71.60108@redhat.com> (raw)
In-Reply-To: <20140321154540.GD8476@work-vm>
Il 21/03/2014 16:45, Dr. David Alan Gilbert ha scritto:
>> > So it looks like your patch could also fix the problem Juan reported
>> > at http://article.gmane.org/gmane.comp.emulators.qemu/247462 -- but
>> > perhaps only on hosts where !KVM || TARGET_PAGE_SIZE==getpagesize().
> Possibly yes; I think that would cause gaps in the bitmap to have
> the same effect as the hot unplug.
It would be nice to revive that patch, because without it you risk
getting bad performance from migration of hotplugged memory. On-board
RAM typically gets low ram_addr_t's that are aligned, but the 128K (32
pages) ROM and the 64K VGA BIOS will ruin the alignment and cause
migration to use the slow paths to migrate hotplugged memory above them.
Paolo
> I'll rework the patch to my less paranoid version from yesterday
> that treats bitmap bits as belonging to only one RAMBlock and repost.
next prev parent reply other threads:[~2014-03-21 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 10:58 [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages Dr. David Alan Gilbert (git)
2014-03-21 13:11 ` Juan Quintela
2014-03-21 13:22 ` Dr. David Alan Gilbert
2014-03-21 15:15 ` Paolo Bonzini
2014-03-21 15:45 ` Dr. David Alan Gilbert
2014-03-21 15:49 ` Paolo Bonzini [this message]
2014-03-21 16:08 ` Juan Quintela
2014-03-21 13:44 ` 陈梁
2014-03-21 14:41 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C5F71.60108@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=dgilbert@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).