[Qemu-devel] [PATCH v3] CODING_STYLE: Section about mixed declarations

[Qemu-devel] [PATCH v3] CODING_STYLE: Section about mixed declarations

[Eduardo Habkost]

We had an unwritten rule about declarations having to be at beginning of
blocks. Make it a written rule.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
Changes v3:
 * Wrap long lines

Changes v2:
 * s/be at beginning/be at the beginning/
---
 CODING_STYLE | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/CODING_STYLE b/CODING_STYLE
index dcbce28..4280945 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -84,3 +84,10 @@ and clarity it comes on a line by itself:
 Rationale: a consistent (except for functions...) bracing style reduces
 ambiguity and avoids needless churn when lines are added or removed.
 Furthermore, it is the QEMU coding style.
+
+5. Declarations
+
+Mixed declarations (interleaving statements and declarations within blocks)
+are not allowed; declarations should be at the beginning of blocks.  In other
+words, the code should not generate warnings if using GCC's
+-Wdeclaration-after-statement option.
-- 
1.8.5.3

Re: [Qemu-devel] [PATCH v3] CODING_STYLE: Section about mixed declarations

[Peter Maydell]

On 17 March 2014 18:26, Eduardo Habkost <ehabkost@redhat.com> wrote:
> We had an unwritten rule about declarations having to be at beginning of
> blocks. Make it a written rule.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] CODING_STYLE: Section about mixed declarations

[Michael Tokarev]

17.03.2014 22:26, Eduardo Habkost wrote:
> We had an unwritten rule about declarations having to be at beginning of
> blocks. Make it a written rule.

Thanks, applied to -trivial.

/mjt

Re: [Qemu-devel] [PATCH v3] CODING_STYLE: Section about mixed declarations

[Fabien Chouteau]

On 03/17/2014 07:26 PM, Eduardo Habkost wrote:
> We had an unwritten rule about declarations having to be at beginning of
> blocks. Make it a written rule.
> 

Hello Eduardo,

Is it possible to check this rule in script/checkpatch.pl? (or is it already?)

Regards,

Re: [Qemu-devel] [PATCH v3] CODING_STYLE: Section about mixed declarations

[Eduardo Habkost]

On Fri, Mar 21, 2014 at 07:04:08PM +0100, Fabien Chouteau wrote:
> On 03/17/2014 07:26 PM, Eduardo Habkost wrote:
> > We had an unwritten rule about declarations having to be at beginning of
> > blocks. Make it a written rule.
> > 
> 
> Hello Eduardo,
> 
> Is it possible to check this rule in script/checkpatch.pl? (or is it already?)

checkpatch.pl doesn't check it, currently. It is possible to check it,
if somebody writes the code to do that.

-- 
Eduardo