From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WR8qZ-0004ik-1o for qemu-devel@nongnu.org; Fri, 21 Mar 2014 19:27:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WR8qU-0003h5-LJ for qemu-devel@nongnu.org; Fri, 21 Mar 2014 19:27:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WR8qU-0003gz-BO for qemu-devel@nongnu.org; Fri, 21 Mar 2014 19:27:26 -0400 Message-ID: <532CCADC.40607@redhat.com> Date: Fri, 21 Mar 2014 17:27:24 -0600 From: Eric Blake MIME-Version: 1.0 References: <1395396763-26081-1-git-send-email-cyliu@suse.com> <1395396763-26081-4-git-send-email-cyliu@suse.com> In-Reply-To: <1395396763-26081-4-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Vlc9FgmFiq0bmaauOKUHqTUBAiB8VbCNI" Subject: Re: [Qemu-devel] [PATCH v23 03/32] qapi: output def_value_str when query command line options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Vlc9FgmFiq0bmaauOKUHqTUBAiB8VbCNI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/21/2014 04:12 AM, Chunyan Liu wrote: > Change qapi interfaces to output the newly added def_value_str when que= rying > command line options. >=20 > Reviewed-by: Eric Blake > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > qapi-schema.json | 6 +++++- > qmp-commands.hx | 2 ++ > util/qemu-config.c | 4 ++++ > 3 files changed, 11 insertions(+), 1 deletion(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index b68cd44..cf9174e 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -4088,12 +4088,16 @@ > # > # @help: #optional human readable text string, not suitable for parsin= g. > # > +# @default: #optional string representation of the default used > +# if the option is omitted. (since 2.0) We've missed 2.0; this needs to be 2.1 now. However, I'm okay if you keep my Reviewed-by with just that change. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Vlc9FgmFiq0bmaauOKUHqTUBAiB8VbCNI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTLMrcAAoJEKeha0olJ0Nq5HMH/3pba+LmAIWbJUTyvhsjijyL nrj3E6/U0oCoPkAS3AHppTYYeQOTmi0Qy4sMcxWUbOkqzPcPnDVQjQL0KY/f1jGV Ac1nCJtCxbPN74XwOVgVGLipyU68+K7Ey8IX2L4pqe0SbqngqT83X3cEYuKS16Bg A9m9rQYcJlLokD5PD9Ns4geSLAjWvIKhJt8Va+d6tlAdJdwi64uWxGS3FFCbnyYD S7WCI3zNIP23yLV50arTM2ocmWeJDDA7BmFKhWnnICZi3qrk/73zQF+KDWxqNpAK 6Yh2AskMloG3bmrlgJvZTOnXQjxbteHFtOjzL3VLfxGnufE3BnSJqQnxfacQ+8c= =uXlm -----END PGP SIGNATURE----- --Vlc9FgmFiq0bmaauOKUHqTUBAiB8VbCNI--