From: Paolo Bonzini <pbonzini@redhat.com>
To: fred.konrad@greensocs.com, qemu-devel@nongnu.org
Cc: mark.burton@greensocs.com
Subject: Re: [Qemu-devel] [RFC PATCH 04/12] icount: introduce icount timer.
Date: Sat, 22 Mar 2014 09:59:34 +0100 [thread overview]
Message-ID: <532D50F6.4040407@redhat.com> (raw)
In-Reply-To: <1395429454-24690-5-git-send-email-fred.konrad@greensocs.com>
Il 21/03/2014 20:17, fred.konrad@greensocs.com ha scritto:
> @@ -154,7 +159,20 @@ int64_t cpu_get_icount(void)
>
> do {
> start = seqlock_read_begin(&timers_state.vm_clock_seqlock);
> - icount = cpu_get_icount_locked();
> + icount = cpu_get_icount_locked(true);
> + } while (seqlock_read_retry(&timers_state.vm_clock_seqlock, start));
> +
> + return icount;
> +}
> +
> +int64_t cpu_get_icount_wo_bias(void)
> +{
> + int64_t icount;
> + unsigned start;
> +
> + do {
> + start = seqlock_read_begin(&timers_state.vm_clock_seqlock);
> + icount = cpu_get_icount_locked(false);
> } while (seqlock_read_retry(&timers_state.vm_clock_seqlock, start));
Why not add an argument to cpu_get_icount() as well?
Paolo
next prev parent reply other threads:[~2014-03-22 8:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 19:17 [Qemu-devel] [RFC PATCH 00/12] Reverse execution fred.konrad
2014-03-21 19:17 ` [Qemu-devel] [RFC PATCH 01/12] icount: put icount variables into TimerState fred.konrad
2014-03-22 8:58 ` Paolo Bonzini
2014-03-21 19:17 ` [Qemu-devel] [RFC PATCH 02/12] migration: migrate icount fields fred.konrad
2014-03-22 8:57 ` Paolo Bonzini
2014-03-24 14:49 ` Frederic Konrad
2014-03-24 15:42 ` Paolo Bonzini
2014-03-25 10:25 ` Frederic Konrad
2014-03-21 19:17 ` [Qemu-devel] [RFC PATCH 03/12] migration: make qemu_savevm_state public fred.konrad
2014-03-21 19:54 ` Dr. David Alan Gilbert
2014-03-24 15:05 ` Frederic Konrad
2014-03-24 17:52 ` Dr. David Alan Gilbert
2014-03-21 19:17 ` [Qemu-devel] [RFC PATCH 04/12] icount: introduce icount timer fred.konrad
2014-03-22 8:59 ` Paolo Bonzini [this message]
2014-03-21 19:17 ` [Qemu-devel] [RFC PATCH 05/12] icount: check for icount clock deadline when cpu loop exits fred.konrad
2014-03-22 8:59 ` Paolo Bonzini
2014-03-21 19:17 ` [Qemu-devel] [RFC PATCH 06/12] icount: make icount extra computed on icount clock as well fred.konrad
2014-03-22 9:00 ` Paolo Bonzini
2014-03-21 19:17 ` [Qemu-devel] [RFC PATCH 07/12] timer: add cpu_icount_to_ns function fred.konrad
2014-03-22 9:00 ` Paolo Bonzini
2014-03-21 19:17 ` [Qemu-devel] [RFC PATCH 08/12] introduce reverse execution mechanism fred.konrad
2014-03-21 19:17 ` [Qemu-devel] [RFC PATCH 09/12] gdbstub: allow reverse execution in gdb stub fred.konrad
2014-03-21 19:17 ` [Qemu-devel] [RFC PATCH 10/12] cpu-exec: trigger a debug request when rexec stops fred.konrad
2014-03-21 19:17 ` [Qemu-devel] [RFC PATCH 11/12] cexe: synchronize icount on the next event fred.konrad
2014-03-21 19:17 ` [Qemu-devel] [RFC PATCH 12/12] cexe: allow to enable reverse execution fred.konrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532D50F6.4040407@redhat.com \
--to=pbonzini@redhat.com \
--cc=fred.konrad@greensocs.com \
--cc=mark.burton@greensocs.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).