From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRHtW-0003XP-K1 for qemu-devel@nongnu.org; Sat, 22 Mar 2014 05:07:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WRHtL-0004xG-AA for qemu-devel@nongnu.org; Sat, 22 Mar 2014 05:07:10 -0400 Received: from mail-ee0-x233.google.com ([2a00:1450:4013:c00::233]:65279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRHtK-0004x3-TP for qemu-devel@nongnu.org; Sat, 22 Mar 2014 05:06:59 -0400 Received: by mail-ee0-f51.google.com with SMTP id c13so2596595eek.10 for ; Sat, 22 Mar 2014 02:06:57 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <532D52AE.4050608@redhat.com> Date: Sat, 22 Mar 2014 10:06:54 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson , qemu-devel@nongnu.org Cc: Markus Armbruster , Luiz Capitulino Il 22/03/2014 00:42, Cole Robinson ha scritto: > Minor error API cleanups, and one error reporting improvement when > connected to qmp (patch #5) > > v2: > Dropped the error_printf_unless_qmp patch > Added the last 4 patches, new cleanups > Use error_report instead of fprintf in patch 1 and 2 > > Cc: Luiz Capitulino > Cc: Markus Armbruster > > Cole Robinson (9): > slirp: Remove default_mon usage > vnc: Remove default_mon usage > error: Privatize error_print_loc > monitor: Remove unused monitor_print_filename > error: Print error_report() to stderr if using qmp > qerror.h: Remove unused error classes > qerror.h: Remove QERR defines that are only used once > qerror.h: Replace QERR_NOT_SUPPORTED with QERR_UNSUPPORTED > error: Remove some unused headers > > block/commit.c | 2 +- > blockdev.c | 9 ++++-- > blockjob.c | 2 +- > hw/9pfs/virtio-9p.c | 5 +-- > hw/core/qdev-properties.c | 9 +++--- > hw/misc/ivshmem.c | 4 +-- > include/monitor/monitor.h | 1 - > include/qapi/qmp/qerror.h | 79 --------------------------------------------- > include/qemu/error-report.h | 1 - > monitor.c | 27 ---------------- > qapi/qmp-dispatch.c | 3 +- > qapi/qmp-input-visitor.c | 2 +- > qdev-monitor.c | 12 ++++--- > qmp.c | 2 +- > qobject/json-parser.c | 2 +- > qom/object.c | 5 +-- > savevm.c | 3 +- > slirp/misc.c | 13 ++------ > slirp/slirp.c | 8 ++--- > slirp/slirp.h | 2 -- > stubs/Makefile.objs | 1 - > stubs/arch-query-cpu-def.c | 2 +- > stubs/mon-print-filename.c | 6 ---- > ui/vnc.c | 4 +-- > util/error.c | 5 +-- > util/qemu-config.c | 2 +- > util/qemu-error.c | 4 +-- > util/qemu-option.c | 2 +- > 28 files changed, 50 insertions(+), 167 deletions(-) > delete mode 100644 stubs/mon-print-filename.c > Nice diffstat. :) Reviewed-by: Paolo Bonzini