From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRPQ1-0007wU-Ft for qemu-devel@nongnu.org; Sat, 22 Mar 2014 13:09:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WRPPr-0007wG-Av for qemu-devel@nongnu.org; Sat, 22 Mar 2014 13:09:13 -0400 Received: from mail-pa0-x236.google.com ([2607:f8b0:400e:c03::236]:62534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRPPr-0007w3-3t for qemu-devel@nongnu.org; Sat, 22 Mar 2014 13:09:03 -0400 Received: by mail-pa0-f54.google.com with SMTP id lf10so3703554pab.13 for ; Sat, 22 Mar 2014 10:09:01 -0700 (PDT) Sender: Richard Henderson Message-ID: <532DC3A4.7020704@twiddle.net> Date: Sat, 22 Mar 2014 10:08:52 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1395081476-6038-1-git-send-email-rth@twiddle.net> <1395081476-6038-14-git-send-email-rth@twiddle.net> <20140322094844.GB12223@zubnet.me.uk> In-Reply-To: <20140322094844.GB12223@zubnet.me.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/14] tcg-sparc: Fix 32-bit constant arguments tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stuart Brady Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org, aurelien@aurel32.net On 03/22/2014 02:48 AM, Stuart Brady wrote: >> + case 'w': >> > + ct->ct |= TCG_CT_CONST_IS32; >> > + break; > It might be neater just to expose ts->type to tcg_target_const_match(), > which the TCG target can just ignore if it wants, but that might not > belong in this series, as this seems to affect PPC64 and IA64 too. > That does sound quite sensible. r~