From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57871)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WRSJL-0002V3-D8
	for qemu-devel@nongnu.org; Sat, 22 Mar 2014 16:14:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WRSJE-0003vb-43
	for qemu-devel@nongnu.org; Sat, 22 Mar 2014 16:14:31 -0400
Received: from cantor2.suse.de ([195.135.220.15]:52838 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WRSJD-0003vV-TE
	for qemu-devel@nongnu.org; Sat, 22 Mar 2014 16:14:24 -0400
Message-ID: <532DEF1E.3050709@suse.de>
Date: Sat, 22 Mar 2014 21:14:22 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1394579440.git.crobinso@redhat.com>	<8da868ef9a5c4a3954ff803cd8913ddb035eb3a8.1394579440.git.crobinso@redhat.com>
	<1394609753.17393.8.camel@nilsson.home.kraxel.org>
In-Reply-To: <1394609753.17393.8.camel@nilsson.home.kraxel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/6] vnc: Remove default_mon usage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>, Cole Robinson <crobinso@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, Markus Armbruster <armbru@redhat.com>, Anthony Liguori <aliguori@amazon.com>, qemu-devel@nongnu.org

Am 12.03.2014 08:35, schrieb Gerd Hoffmann:
> On Di, 2014-03-11 at 19:15 -0400, Cole Robinson wrote:
>> These errors don't seem user initiated, so forcibly printing to the
>> monitor doesn't seem right. Just print to stderr.
>>
>> Cc: Anthony Liguori <aliguori@amazon.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Signed-off-by: Cole Robinson <crobinso@redhat.com>
>=20
> Reviewed-by: Gerd Hoffmann <kraxel@gmail.com>

Both should use error_report(), no? We really need clear-to-understand
rules of when to use which API and then stick with them.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg