From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRxpj-00043x-R4 for qemu-devel@nongnu.org; Mon, 24 Mar 2014 01:54:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WRxpd-0003jV-Ra for qemu-devel@nongnu.org; Mon, 24 Mar 2014 01:54:03 -0400 Received: from mail-pb0-f41.google.com ([209.85.160.41]:40244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRxpd-0003ho-LW for qemu-devel@nongnu.org; Mon, 24 Mar 2014 01:53:57 -0400 Received: by mail-pb0-f41.google.com with SMTP id jt11so4976624pbb.14 for ; Sun, 23 Mar 2014 22:53:56 -0700 (PDT) Message-ID: <532FC86E.2060806@ozlabs.ru> Date: Mon, 24 Mar 2014 16:53:50 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1394088217-4504-1-git-send-email-aik@ozlabs.ru> <87bnxjo2f3.fsf@pixel.localdomain> <53228F11.1020801@ozlabs.ru> <532DF031.40209@suse.de> <532DFAE8.90704@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , =?UTF-8?B?QW5kcmVhcyBGw6RyYg==?= =?UTF-8?B?ZXI=?= Cc: Mike Day , Gerd Hoffmann , QEMU Developers On 03/23/2014 08:23 AM, Peter Maydell wrote: > On 22 March 2014 21:04, Andreas Färber wrote: >> Am 22.03.2014 21:54, schrieb Peter Maydell: >>> On 22 March 2014 20:18, Andreas Färber wrote: >>>> Because AFAIU >>>> migration is possible without VMSD, just not with VMSD that sets >>>> .unmigratable = 1. >>> >>> Well, the migration won't fail with an error, but on the destination >>> end you'll end up with a device in its reset state but a guest which >>> may think the device is in some other state. If the device was >>> quiescent and doesn't need complex setup it might cope, but >>> more likely is that that guest driver will fall over in a heap next >>> time you try to use it... >> >> Well, there is no OHCI state being added, only PCI state. So I'd be >> curious to know what in there is the problem because a general review of >> PCI devices might be due then - and ideally before we do the release. > > Oops, I hadn't noticed that; this patch is incorrect, then, because > vmstate_ohci needs to include a line for the OHCIState, and we > need a second vmstate struct for the OHCIState. Sorry but what is incorrect in the patch? I can understand that it is incomplete as it is missing OHCI-specific bits from the OHCIState state and I can do that but I need some hints what is really necessary. So far the USB device was able to recover, only PCI bits were really needed. Thanks. -- Alexey