From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS2eD-0000aE-5T for qemu-devel@nongnu.org; Mon, 24 Mar 2014 07:02:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WS2e1-0001SD-5v for qemu-devel@nongnu.org; Mon, 24 Mar 2014 07:02:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47624 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS2e0-0001S2-UA for qemu-devel@nongnu.org; Mon, 24 Mar 2014 07:02:17 -0400 Message-ID: <533010B6.8050609@suse.de> Date: Mon, 24 Mar 2014 12:02:14 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1395350099-14664-1-git-send-email-marcel.a@redhat.com> <532B645B.5020507@redhat.com> <1395353214.21800.6.camel@localhost.localdomain> <532B6B27.2080105@redhat.com> <1395354837.21800.12.camel@localhost.localdomain> <532B76E5.7090608@redhat.com> <20140323094943.GA6989@redhat.com> In-Reply-To: <20140323094943.GA6989@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Paolo Bonzini , aik@ozlabs.ru Cc: peter.maydell@linaro.org, Marcel Apfelbaum , mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com, Laszlo Ersek , rth@twiddle.net Am 23.03.2014 10:49, schrieb Michael S. Tsirkin: > On Fri, Mar 21, 2014 at 12:16:53AM +0100, Paolo Bonzini wrote: >> Il 20/03/2014 23:33, Marcel Apfelbaum ha scritto: >>> I've seen something like that somewhere, but I didn't quite like it. >>> I was looking for something more elegant as I was *almost* sure >>> this kind of solution will not pass the reviews :) >>> >>> But maybe I'll try this, let's see what happens, >> >> If all you're looking for is bigendian (disabling iasl disassembly >> on bigendian makes sense), your patch v2 is fine. >> >> Assembling ASL on bigendian is supported by at least Fedora and >> Debian (and hence Ubuntu). >> >> Paolo >=20 >=20 > At this point I'm confused. > If iasl compiler is broken, we should detect and fix that. > It might be ok to just detect endian-ness as a quick work-around. > BTW configure already has code to detect endian-ness: > if test "$bigendian" =3D "yes" ; then > echo "HOST_WORDS_BIGENDIAN=3Dy" >> $config_host_mak > fi Careful, this is about the endianness of the built target binary, which may be different from the endianness of the build system. However I would hope the tests will not be executed for cross-builds. Alexey, you're using cross-builds for ppc, right? Have you ever tested running make check there? Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg