From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59665)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WS5DG-0002AY-CA
	for qemu-devel@nongnu.org; Mon, 24 Mar 2014 09:46:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WS5Cs-0000kY-H0
	for qemu-devel@nongnu.org; Mon, 24 Mar 2014 09:46:35 -0400
Received: from cantor2.suse.de ([195.135.220.15]:51309 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WS5Cs-0000kS-As
	for qemu-devel@nongnu.org; Mon, 24 Mar 2014 09:46:26 -0400
Message-ID: <53303730.4090301@suse.de>
Date: Mon, 24 Mar 2014 14:46:24 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1394579440.git.crobinso@redhat.com>	<150e59818a7f8a0c5928f9f08d31c2248029ab57.1394579440.git.crobinso@redhat.com>	<532DED51.6040706@suse.de>
	<20140324090916.543e00ea@redhat.com>
In-Reply-To: <20140324090916.543e00ea@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 4/6] monitor: Remove unused
	monitor_print_filename
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Cole Robinson <crobinso@redhat.com>

Am 24.03.2014 14:09, schrieb Luiz Capitulino:
> On Sat, 22 Mar 2014 21:06:41 +0100
> Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>=20
>> Am 12.03.2014 00:15, schrieb Cole Robinson:
>>> Cc: Luiz Capitulino <lcapitulino@redhat.com>
>>> Cc: Markus Armbruster <armbru@redhat.com>
>>> Signed-off-by: Cole Robinson <crobinso@redhat.com>
>>
>> Given that it even had its own stub file, the commit message should
>> please explain why it is no longer needed and thus okay to drop.
>=20
> Because it's unused?

That's no real answer. Why did it need to be escaped before the commit
Cole pointed to and now no longer is?

My point was that someone went throught the hassle of creating a stub
file just for this functionality, so it's not some random unused
function in some file. (But I'm not particularly attached to it, just
cautioning about removing too much in this non-verbose way, making it
hard to follow for outsiders.)

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg