From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS6Xe-0008A6-Ji for qemu-devel@nongnu.org; Mon, 24 Mar 2014 11:12:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WS6XZ-0003AZ-BR for qemu-devel@nongnu.org; Mon, 24 Mar 2014 11:11:58 -0400 Received: from greensocs.com ([178.33.234.66]:56485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS6XZ-0003AA-53 for qemu-devel@nongnu.org; Mon, 24 Mar 2014 11:11:53 -0400 Message-ID: <5330499F.2080503@greensocs.com> Date: Mon, 24 Mar 2014 16:05:03 +0100 From: Frederic Konrad MIME-Version: 1.0 References: <1395429454-24690-1-git-send-email-fred.konrad@greensocs.com> <1395429454-24690-4-git-send-email-fred.konrad@greensocs.com> <20140321195415.GD14504@work-vm> In-Reply-To: <20140321195415.GD14504@work-vm> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 03/12] migration: make qemu_savevm_state public. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: mrhines@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, quintela@redhat.com On 21/03/2014 20:54, Dr. David Alan Gilbert wrote: > * fred.konrad@greensocs.com (fred.konrad@greensocs.com) wrote: >> From: KONRAD Frederic >> >> This makes qemu_savevm_state public for reverse-execution. > It's interesting that you're doing this repetitive snapshot; > in some ways it's similar to Michael Hines's code for > Fault tolerance ( http://lists.gnu.org/archive/html/qemu-devel/2014-02/msg03042.html ) > > Dave Hi, Thanks for the link I missed this. Seems mc is using live migration and we just checkpoint the whole machine. That might be a good improvment. Fred > >> Signed-off-by: KONRAD Frederic >> --- >> include/sysemu/sysemu.h | 1 + >> savevm.c | 2 +- >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h >> index 3915ce3..fe86615 100644 >> --- a/include/sysemu/sysemu.h >> +++ b/include/sysemu/sysemu.h >> @@ -78,6 +78,7 @@ void do_info_snapshots(Monitor *mon, const QDict *qdict); >> >> void qemu_announce_self(void); >> >> +int qemu_savevm_state(QEMUFile *f); >> bool qemu_savevm_state_blocked(Error **errp); >> void qemu_savevm_state_begin(QEMUFile *f, >> const MigrationParams *params); >> diff --git a/savevm.c b/savevm.c >> index d094fbb..e50b716 100644 >> --- a/savevm.c >> +++ b/savevm.c >> @@ -635,7 +635,7 @@ void qemu_savevm_state_cancel(void) >> } >> } >> >> -static int qemu_savevm_state(QEMUFile *f) >> +int qemu_savevm_state(QEMUFile *f) >> { >> int ret; >> MigrationParams params = { >> -- >> 1.8.1.4 >> >> > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK >