From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS6sX-0006Vv-Cc for qemu-devel@nongnu.org; Mon, 24 Mar 2014 11:33:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WS6sO-0001FW-6e for qemu-devel@nongnu.org; Mon, 24 Mar 2014 11:33:33 -0400 Received: from mail-qc0-x22b.google.com ([2607:f8b0:400d:c01::22b]:40778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS6sO-0001FK-22 for qemu-devel@nongnu.org; Mon, 24 Mar 2014 11:33:24 -0400 Received: by mail-qc0-f171.google.com with SMTP id c9so6122857qcz.2 for ; Mon, 24 Mar 2014 08:33:23 -0700 (PDT) Sender: Richard Henderson Message-ID: <5330503F.3000209@twiddle.net> Date: Mon, 24 Mar 2014 08:33:19 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1394851732-25692-1-git-send-email-rth@twiddle.net> <1394851732-25692-2-git-send-email-rth@twiddle.net> <5330116A.9010702@huawei.com> In-Reply-To: <5330116A.9010702@huawei.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/26] tcg-aarch64: Properly detect SIGSEGV writes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Claudio Fontana , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, claudio.fontana@gmail.com On 03/24/2014 04:05 AM, Claudio Fontana wrote: >> (insn & 0xbfff0000) == 0x0c000000 /* C3.3.1 */ >> > + || (insn & 0xbfe00000) == 0x0c800000 /* C3.3.2 */ >> > + || (insn & 0xbfff0000) == 0x0d000000 /* C3.3.3 */ > I see you exclude the instructions with bit R=1. > Is there a reason why 'R'(eplicate) instructions are not to be considered stores here? > No, that's just a failure to read the tables properly. Will fix. r~