From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS74Y-0007wR-JY for qemu-devel@nongnu.org; Mon, 24 Mar 2014 11:46:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WS74S-0005KH-Fd for qemu-devel@nongnu.org; Mon, 24 Mar 2014 11:45:58 -0400 Message-ID: <53305328.6070307@redhat.com> Date: Mon, 24 Mar 2014 16:45:44 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1395675886-3357-1-git-send-email-prasadjoshi.linux@gmail.com> In-Reply-To: <1395675886-3357-1-git-send-email-prasadjoshi.linux@gmail.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr_vscsi: remove duplicate condition check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasad Joshi Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com, agraf@suse.de Il 24/03/2014 16:44, Prasad Joshi ha scritto: > Signed-off-by: Prasad Joshi > --- > hw/scsi/spapr_vscsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c > index 34478f0..d4ada4f 100644 > --- a/hw/scsi/spapr_vscsi.c > +++ b/hw/scsi/spapr_vscsi.c > @@ -690,7 +690,7 @@ static void vscsi_inquiry_no_target(VSCSIState *s, vscsi_req *req) > int rc, len, alen; > > /* We dont do EVPD. Also check that page_code is 0 */ > - if ((cdb[1] & 0x01) || (cdb[1] & 0x01) || cdb[2] != 0) { > + if ((cdb[1] & 0x01) || cdb[2] != 0) { > /* Send INVALID FIELD IN CDB */ > vscsi_makeup_sense(s, req, ILLEGAL_REQUEST, 0x24, 0); > vscsi_send_rsp(s, req, CHECK_CONDITION, 0, 0); > Not trivial---I have no idea if something else was meant to be checked. Paolo