From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS761-0001JP-Kn for qemu-devel@nongnu.org; Mon, 24 Mar 2014 11:47:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WS75w-0005dB-SC for qemu-devel@nongnu.org; Mon, 24 Mar 2014 11:47:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS75w-0005cy-KH for qemu-devel@nongnu.org; Mon, 24 Mar 2014 11:47:24 -0400 Message-ID: <5330537E.7060001@redhat.com> Date: Mon, 24 Mar 2014 16:47:10 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1395666264-12060-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1395666264-12060-1-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: quintela@redhat.com, zengjunliang , yanqiangjun@huawei.com, lefty.zhao@huawei.com, owasserm@redhat.com Il 24/03/2014 14:04, arei.gonglei@huawei.com ha scritto: > From: zengjunliang > > Return error for migrate cancel, when migration status is not > MIG_STATE_SETUP or MIG_STATE_ACTIVE. Thus, libvirt can can > perceive the operation fails. > > Signed-off-by: zengjunliang > Signed-off-by: Gonglei I think this is done on purpose, because canceling migration is racy. Instead, libvirt should do "query-migrate" and check if the migration was completed or canceled. Paolo