* [Qemu-devel] [PATCH RFT for-2.0-rc1] make-release: Record SeaBIOS version
@ 2014-03-20 1:01 Andreas Färber
2014-03-20 8:04 ` Gerd Hoffmann
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2014-03-20 1:01 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, Andreas Färber, anthony, Gerd Hoffmann
Before deleting .git, determine the version and save it in .version file.
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
scripts/make-release | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/make-release b/scripts/make-release
index 186358d..fa6323f 100755
--- a/scripts/make-release
+++ b/scripts/make-release
@@ -18,6 +18,7 @@ git clone "${src}" ${destination}
pushd ${destination}
git checkout "v${version}"
git submodule update --init
+(cd roms/seabios && git describe --tags --long --dirty > .version)
rm -rf .git roms/*/.git dtc/.git pixman/.git
popd
tar cfj ${destination}.tar.bz2 ${destination}
--
1.8.4.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH RFT for-2.0-rc1] make-release: Record SeaBIOS version
2014-03-20 1:01 [Qemu-devel] [PATCH RFT for-2.0-rc1] make-release: Record SeaBIOS version Andreas Färber
@ 2014-03-20 8:04 ` Gerd Hoffmann
2014-03-25 15:31 ` Andreas Färber
0 siblings, 1 reply; 4+ messages in thread
From: Gerd Hoffmann @ 2014-03-20 8:04 UTC (permalink / raw)
To: Andreas Färber; +Cc: peter.maydell, qemu-devel, anthony
> +(cd roms/seabios && git describe --tags --long --dirty > .version)
> rm -rf .git roms/*/.git dtc/.git pixman/.git
Looks good. Mimics what roms/seabios/scripts/buildversion.sh is doing
in case .git is present.
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
cheers,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH RFT for-2.0-rc1] make-release: Record SeaBIOS version
2014-03-20 8:04 ` Gerd Hoffmann
@ 2014-03-25 15:31 ` Andreas Färber
2014-03-31 16:40 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2014-03-25 15:31 UTC (permalink / raw)
To: peter.maydell, anthony; +Cc: Gerd Hoffmann, qemu-devel
Am 20.03.2014 09:04, schrieb Gerd Hoffmann:
>> +(cd roms/seabios && git describe --tags --long --dirty > .version)
>> rm -rf .git roms/*/.git dtc/.git pixman/.git
>
> Looks good. Mimics what roms/seabios/scripts/buildversion.sh is doing
> in case .git is present.
>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Ping! I have meanwhile confirmed that a roms/seabios/.version file with
the expected contents gets included in the tarball with this patch.
Anthony, can you please confirm and use? Thanks!
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH RFT for-2.0-rc1] make-release: Record SeaBIOS version
2014-03-25 15:31 ` Andreas Färber
@ 2014-03-31 16:40 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2014-03-31 16:40 UTC (permalink / raw)
To: Andreas Färber; +Cc: Gerd Hoffmann, Anthony Liguori, QEMU Developers
On 25 March 2014 15:31, Andreas Färber <afaerber@suse.de> wrote:
> Am 20.03.2014 09:04, schrieb Gerd Hoffmann:
>>> +(cd roms/seabios && git describe --tags --long --dirty > .version)
>>> rm -rf .git roms/*/.git dtc/.git pixman/.git
>>
>> Looks good. Mimics what roms/seabios/scripts/buildversion.sh is doing
>> in case .git is present.
>>
>> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Ping! I have meanwhile confirmed that a roms/seabios/.version file with
> the expected contents gets included in the tarball with this patch.
Applied to master, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-31 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-20 1:01 [Qemu-devel] [PATCH RFT for-2.0-rc1] make-release: Record SeaBIOS version Andreas Färber
2014-03-20 8:04 ` Gerd Hoffmann
2014-03-25 15:31 ` Andreas Färber
2014-03-31 16:40 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).