From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSZ5P-0001bm-A2 for qemu-devel@nongnu.org; Tue, 25 Mar 2014 17:40:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSZ5K-0006MR-Ef for qemu-devel@nongnu.org; Tue, 25 Mar 2014 17:40:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSZ5K-0006MD-4H for qemu-devel@nongnu.org; Tue, 25 Mar 2014 17:40:38 -0400 Message-ID: <5331F7D4.3000502@redhat.com> Date: Tue, 25 Mar 2014 15:40:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1395396763-26081-1-git-send-email-cyliu@suse.com> <1395396763-26081-10-git-send-email-cyliu@suse.com> In-Reply-To: <1395396763-26081-10-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h0vX4LKWxhjsMbqk8UnlHCjtTBUbmlPLn" Subject: Re: [Qemu-devel] [PATCH v23 09/32] add qemu_opts_append to repalce append_option_parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --h0vX4LKWxhjsMbqk8UnlHCjtTBUbmlPLn Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/21/2014 04:12 AM, Chunyan Liu wrote: s/repalce/replace/ in subject Also, your overall series could probably use subject lines with a prefix that makes it obvious they are related to a common category; maybe "opts:= ". > For later merge .create_opts of drv and proto_drv in qemu-img commands.= >=20 > Signed-off-by: Chunyan Liu > --- > + > +/* Realloc dst option list and append options either from an option li= st (list) > + * or an QEMUOptionParameter (param) to it. dst could be NULL or a mal= loced list. s/an QEMU/a QEMU/ > + * FIXME: will remove QEMUOptionParameter after all drivers switch to = QemuOpts. > + */ > +QemuOptsList *qemu_opts_append(QemuOptsList *dst, > + QemuOptsList *list, > + QEMUOptionParameter *param) > +{ > + size_t num_opts, num_dst_opts; > + QemuOptsList *tmp_list =3D NULL; > + QemuOptDesc *desc; > + bool need_init =3D false; > + > + assert(!(list && param)); > + if (!param &&!list) { Space after && --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --h0vX4LKWxhjsMbqk8UnlHCjtTBUbmlPLn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTMffUAAoJEKeha0olJ0NqceMH/1TqhM6R5iQIe2IKnTO1gPtX SwiYa+4zVeH6eCe2Qb5B7Z1VGjsBoI/bttfwoglNf748N6Ypl4tc5QXsQR6WdDlA L91qbM/jbULA8KfCy/ow2zvmYLcrhYxdx7g3eQFO40ouwGu1EzHtPtI3FGb+iY8/ T/P+v8ab+EjtNMFsacfsdsBjkKRFreHL0/fURE26fuMJ1mRot7JCrOQw/5o1pYfi fsP5oJrYg4MW9GWJZQw7zPbzVsPob6TgpDzvd/nxXaEMz7teAffr8lyKhu0C3VaM LRhPtBaCkL9+GmqJn7by+Un1AE70e4leWAnKerAPvm7wfhX6nBv4I6STNWhi7ak= =T9FK -----END PGP SIGNATURE----- --h0vX4LKWxhjsMbqk8UnlHCjtTBUbmlPLn--