From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSd0P-0003qb-63 for qemu-devel@nongnu.org; Tue, 25 Mar 2014 21:51:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSd0J-0004NA-Ud for qemu-devel@nongnu.org; Tue, 25 Mar 2014 21:51:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSd0J-0004Mh-LR for qemu-devel@nongnu.org; Tue, 25 Mar 2014 21:51:43 -0400 Message-ID: <533232AC.6090300@redhat.com> Date: Tue, 25 Mar 2014 19:51:40 -0600 From: Eric Blake MIME-Version: 1.0 References: <1395793183-19894-1-git-send-email-akong@redhat.com> In-Reply-To: <1395793183-19894-1-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nM7GPhOPLfLlJ8LSL2dRfQTjARQcmt5f4" Subject: Re: [Qemu-devel] [PATCH v4 for 2.0] virtio-net: add vlan receive state to RxFilterInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong , qemu-devel@nongnu.org Cc: vyasevic@redhat.com, mst@redhat.com, sf@sfritsch.de, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nM7GPhOPLfLlJ8LSL2dRfQTjARQcmt5f4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/25/2014 06:19 PM, Amos Kong wrote: > Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't= > filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiat= ed. >=20 > This patch added a new field to @RxFilterInfo to indicate vlan receive > state ('normal', 'none', 'all'). If VIRTIO_NET_F_CTRL_VLAN isn't > negotiated, vlan receive state will be 'all', then all VLAN-tagged pack= ets > will be received by guest. >=20 > This patch also fixed a boundary issue in visiting vlan table. The use of "also" means this might have been better as two patches (bug fix separate from qapi addition). But as we are getting close to 2.0, I'm okay if you add: >=20 > [1] http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg02604.ht= ml >=20 > Signed-off-by: Amos Kong > --- Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nM7GPhOPLfLlJ8LSL2dRfQTjARQcmt5f4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTMjKsAAoJEKeha0olJ0NqjKgH/0HkI+kRgv2ftwpR/+5ax9WI ObgE69luRhaa8MdFUuEp5lHRYv3ZbV9lESIu0j51MZ30Yv8qR/PCbV/2gu5OiLeO jA6/aLt8VZWE/75w9O9pV2O1rTN3Nlr4B5ZzNE9VlaXvyBtmNFIiY4yoVbVjkN5R ISDRRXmhV4PjxoW3jtVYo+U6S3ttB2V3A2cXbLgwuqmlSItSAfwJWFwEjtbbRa+7 Wj87dTFsUVBTepkM2ngK7HoTg8CVkDAkq3OAULhW8JISFNTltmtB4ewBlKDyUhju oiJXey5bYG/1SLYI0DUrfMzHm5UfcgsbfWHJ8drOBqhZFRhe7LYJCCxcXnRue84= =fMxF -----END PGP SIGNATURE----- --nM7GPhOPLfLlJ8LSL2dRfQTjARQcmt5f4--