From: Claudio Fontana <claudio.fontana@huawei.com>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, claudio.fontana@gmail.com
Subject: Re: [Qemu-devel] [PATCH 19/26] tcg-aarch64: Implement TCG_TARGET_HAS_new_ldst
Date: Wed, 26 Mar 2014 10:40:12 +0100 [thread overview]
Message-ID: <5332A07C.2030304@huawei.com> (raw)
In-Reply-To: <1394851732-25692-20-git-send-email-rth@twiddle.net>
On 15.03.2014 03:48, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> tcg/aarch64/tcg-target.c | 101 ++++++++++++++++++-----------------------------
> tcg/aarch64/tcg-target.h | 2 +-
> 2 files changed, 39 insertions(+), 64 deletions(-)
>
> diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
> index 3920f99..fa1a45d 100644
> --- a/tcg/aarch64/tcg-target.c
> +++ b/tcg/aarch64/tcg-target.c
> @@ -1038,21 +1038,27 @@ static inline void tcg_out_addsub2(TCGContext *s, int ext, TCGReg rl,
> /* helper signature: helper_ret_ld_mmu(CPUState *env, target_ulong addr,
> * int mmu_idx, uintptr_t ra)
> */
> -static const void * const qemu_ld_helpers[4] = {
> - helper_ret_ldub_mmu,
> - helper_ret_lduw_mmu,
> - helper_ret_ldul_mmu,
> - helper_ret_ldq_mmu,
> +static const void * const qemu_ld_helpers[16] = {
> + [MO_UB] = helper_ret_ldub_mmu,
> + [MO_LEUW] = helper_le_lduw_mmu,
> + [MO_LEUL] = helper_le_ldul_mmu,
> + [MO_LEQ] = helper_le_ldq_mmu,
> + [MO_BEUW] = helper_be_lduw_mmu,
> + [MO_BEUL] = helper_be_ldul_mmu,
> + [MO_BEQ] = helper_be_ldq_mmu,
> };
>
> /* helper signature: helper_ret_st_mmu(CPUState *env, target_ulong addr,
> * uintxx_t val, int mmu_idx, uintptr_t ra)
> */
> -static const void * const qemu_st_helpers[4] = {
> - helper_ret_stb_mmu,
> - helper_ret_stw_mmu,
> - helper_ret_stl_mmu,
> - helper_ret_stq_mmu,
> +static const void * const qemu_st_helpers[16] = {
> + [MO_UB] = helper_ret_stb_mmu,
> + [MO_LEUW] = helper_le_stw_mmu,
> + [MO_LEUL] = helper_le_stl_mmu,
> + [MO_LEQ] = helper_le_stq_mmu,
> + [MO_BEUW] = helper_be_stw_mmu,
> + [MO_BEUL] = helper_be_stl_mmu,
> + [MO_BEQ] = helper_be_stq_mmu,
> };
>
> static inline void tcg_out_adr(TCGContext *s, TCGReg rd, uintptr_t addr)
> @@ -1073,7 +1079,7 @@ static void tcg_out_qemu_ld_slow_path(TCGContext *s, TCGLabelQemuLdst *lb)
> tcg_out_movr(s, TARGET_LONG_BITS == 64, TCG_REG_X1, lb->addrlo_reg);
> tcg_out_movi(s, TCG_TYPE_I32, TCG_REG_X2, lb->mem_index);
> tcg_out_adr(s, TCG_REG_X3, (intptr_t)lb->raddr);
> - tcg_out_call(s, (intptr_t)qemu_ld_helpers[size]);
> + tcg_out_call(s, (intptr_t)qemu_ld_helpers[opc & ~MO_SIGN]);
> if (opc & MO_SIGN) {
> tcg_out_sxt(s, TCG_TYPE_I64, size, lb->datalo_reg, TCG_REG_X0);
> } else {
> @@ -1085,7 +1091,8 @@ static void tcg_out_qemu_ld_slow_path(TCGContext *s, TCGLabelQemuLdst *lb)
>
> static void tcg_out_qemu_st_slow_path(TCGContext *s, TCGLabelQemuLdst *lb)
> {
> - TCGMemOp size = lb->opc;
> + TCGMemOp opc = lb->opc;
> + TCGMemOp size = opc & MO_SIZE;
>
> reloc_pc19(lb->label_ptr[0], (intptr_t)s->code_ptr);
>
> @@ -1094,7 +1101,7 @@ static void tcg_out_qemu_st_slow_path(TCGContext *s, TCGLabelQemuLdst *lb)
> tcg_out_movr(s, size == MO_64, TCG_REG_X2, lb->datalo_reg);
> tcg_out_movi(s, TCG_TYPE_I32, TCG_REG_X3, lb->mem_index);
> tcg_out_adr(s, TCG_REG_X4, (intptr_t)lb->raddr);
> - tcg_out_call(s, (intptr_t)qemu_st_helpers[size]);
> + tcg_out_call(s, (intptr_t)qemu_st_helpers[opc]);
> tcg_out_goto(s, (intptr_t)lb->raddr);
> }
>
> @@ -1262,9 +1269,10 @@ static void tcg_out_qemu_st_direct(TCGContext *s, TCGMemOp memop,
> }
> }
>
> -static void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args, TCGMemOp memop)
> +static void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args)
> {
> TCGReg addr_reg, data_reg;
> + TCGMemOp memop;
> #ifdef CONFIG_SOFTMMU
> int mem_index;
> TCGMemOp s_bits;
> @@ -1272,9 +1280,10 @@ static void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args, TCGMemOp memop)
> #endif
> data_reg = args[0];
> addr_reg = args[1];
> + memop = args[2];
>
> #ifdef CONFIG_SOFTMMU
> - mem_index = args[2];
> + mem_index = args[3];
> s_bits = memop & MO_SIZE;
> tcg_out_tlb_read(s, addr_reg, s_bits, &label_ptr, mem_index, 1);
> tcg_out_qemu_ld_direct(s, memop, data_reg, addr_reg, TCG_REG_X1);
> @@ -1286,9 +1295,10 @@ static void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args, TCGMemOp memop)
> #endif /* CONFIG_SOFTMMU */
> }
>
> -static void tcg_out_qemu_st(TCGContext *s, const TCGArg *args, TCGMemOp memop)
> +static void tcg_out_qemu_st(TCGContext *s, const TCGArg *args)
> {
> TCGReg addr_reg, data_reg;
> + TCGMemOp memop;
> #ifdef CONFIG_SOFTMMU
> int mem_index;
> TCGMemOp s_bits;
> @@ -1296,9 +1306,10 @@ static void tcg_out_qemu_st(TCGContext *s, const TCGArg *args, TCGMemOp memop)
> #endif
> data_reg = args[0];
> addr_reg = args[1];
> + memop = args[2];
>
> #ifdef CONFIG_SOFTMMU
> - mem_index = args[2];
> + mem_index = args[3];
> s_bits = memop & MO_SIZE;
>
> tcg_out_tlb_read(s, addr_reg, s_bits, &label_ptr, mem_index, 0);
> @@ -1578,39 +1589,13 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
> tcg_out_insn(s, 3506, CSEL, ext, a0, REG0(3), REG0(4), args[5]);
> break;
>
> - case INDEX_op_qemu_ld8u:
> - tcg_out_qemu_ld(s, args, MO_UB);
> - break;
> - case INDEX_op_qemu_ld8s:
> - tcg_out_qemu_ld(s, args, MO_SB);
> - break;
> - case INDEX_op_qemu_ld16u:
> - tcg_out_qemu_ld(s, args, MO_TEUW);
> - break;
> - case INDEX_op_qemu_ld16s:
> - tcg_out_qemu_ld(s, args, MO_TESW);
> - break;
> - case INDEX_op_qemu_ld32u:
> - case INDEX_op_qemu_ld32:
> - tcg_out_qemu_ld(s, args, MO_TEUL);
> - break;
> - case INDEX_op_qemu_ld32s:
> - tcg_out_qemu_ld(s, args, MO_TESL);
> + case INDEX_op_qemu_ld_i32:
> + case INDEX_op_qemu_ld_i64:
> + tcg_out_qemu_ld(s, args);
> break;
> - case INDEX_op_qemu_ld64:
> - tcg_out_qemu_ld(s, args, MO_TEQ);
> - break;
> - case INDEX_op_qemu_st8:
> - tcg_out_qemu_st(s, args, MO_UB);
> - break;
> - case INDEX_op_qemu_st16:
> - tcg_out_qemu_st(s, args, MO_TEUW);
> - break;
> - case INDEX_op_qemu_st32:
> - tcg_out_qemu_st(s, args, MO_TEUL);
> - break;
> - case INDEX_op_qemu_st64:
> - tcg_out_qemu_st(s, args, MO_TEQ);
> + case INDEX_op_qemu_st_i32:
> + case INDEX_op_qemu_st_i64:
> + tcg_out_qemu_st(s, args);
> break;
>
> case INDEX_op_bswap32_i64:
> @@ -1776,20 +1761,10 @@ static const TCGTargetOpDef aarch64_op_defs[] = {
> { INDEX_op_movcond_i32, { "r", "r", "rwA", "rZ", "rZ" } },
> { INDEX_op_movcond_i64, { "r", "r", "rA", "rZ", "rZ" } },
>
> - { INDEX_op_qemu_ld8u, { "r", "l" } },
> - { INDEX_op_qemu_ld8s, { "r", "l" } },
> - { INDEX_op_qemu_ld16u, { "r", "l" } },
> - { INDEX_op_qemu_ld16s, { "r", "l" } },
> - { INDEX_op_qemu_ld32u, { "r", "l" } },
> - { INDEX_op_qemu_ld32s, { "r", "l" } },
> -
> - { INDEX_op_qemu_ld32, { "r", "l" } },
> - { INDEX_op_qemu_ld64, { "r", "l" } },
> -
> - { INDEX_op_qemu_st8, { "l", "l" } },
> - { INDEX_op_qemu_st16, { "l", "l" } },
> - { INDEX_op_qemu_st32, { "l", "l" } },
> - { INDEX_op_qemu_st64, { "l", "l" } },
> + { INDEX_op_qemu_ld_i32, { "r", "l" } },
> + { INDEX_op_qemu_ld_i64, { "r", "l" } },
> + { INDEX_op_qemu_st_i32, { "l", "l" } },
> + { INDEX_op_qemu_st_i64, { "l", "l" } },
>
> { INDEX_op_bswap16_i32, { "r", "r" } },
> { INDEX_op_bswap32_i32, { "r", "r" } },
> diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h
> index faccc36..adf0261 100644
> --- a/tcg/aarch64/tcg-target.h
> +++ b/tcg/aarch64/tcg-target.h
> @@ -98,7 +98,7 @@ typedef enum {
> #define TCG_TARGET_HAS_muluh_i64 1
> #define TCG_TARGET_HAS_mulsh_i64 1
>
> -#define TCG_TARGET_HAS_new_ldst 0
> +#define TCG_TARGET_HAS_new_ldst 1
>
> static inline void flush_icache_range(uintptr_t start, uintptr_t stop)
> {
>
Reviewed-by: Claudio Fontana <claudio.fontana@huawei.com>
next prev parent reply other threads:[~2014-03-26 9:40 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 2:48 [Qemu-devel] [PATCH 00/26] tcg/aarch64 improvements, part 3 Richard Henderson
2014-03-15 2:48 ` [Qemu-devel] [PATCH 01/26] tcg-aarch64: Properly detect SIGSEGV writes Richard Henderson
2014-03-24 11:05 ` Claudio Fontana
2014-03-24 15:33 ` Richard Henderson
2014-03-24 11:45 ` Claudio Fontana
2014-03-24 12:17 ` Peter Maydell
2014-03-24 12:41 ` Peter Maydell
2014-03-24 15:27 ` Richard Henderson
2014-03-15 2:48 ` [Qemu-devel] [PATCH 02/26] tcg-aarch64: Use intptr_t apropriately Richard Henderson
2014-03-24 12:12 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 03/26] tcg-aarch64: Use TCGType and TCGMemOp constants Richard Henderson
2014-03-24 12:52 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 04/26] tcg-aarch64: Use MOVN in tcg_out_movi Richard Henderson
2014-03-24 14:06 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 05/26] tcg-aarch64: Use ORRI " Richard Henderson
2014-03-24 14:06 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 06/26] tcg-aarch64: Special case small constants " Richard Henderson
2014-03-24 14:08 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 07/26] tcg-aarch64: Use adrp " Richard Henderson
2014-03-24 14:05 ` Claudio Fontana
2014-03-24 15:36 ` Richard Henderson
2014-03-26 9:34 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 08/26] tcg-aarch64: Use symbolic names for branches Richard Henderson
2014-03-24 15:31 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 09/26] tcg-aarch64: Create tcg_out_brcond Richard Henderson
2014-03-24 15:31 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 10/26] tcg-aarch64: Use CBZ and CBNZ Richard Henderson
2014-03-24 15:32 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 11/26] tcg-aarch64: Reuse FP and LR in translated code Richard Henderson
2014-03-28 9:48 ` Claudio Fontana
2014-03-28 13:23 ` Richard Henderson
2014-03-15 2:48 ` [Qemu-devel] [PATCH 12/26] tcg-aarch64: Introduce tcg_out_insn_3314 Richard Henderson
2014-03-15 2:48 ` [Qemu-devel] [PATCH 13/26] tcg-aarch64: Rearrange prologue insn order Richard Henderson
2014-03-15 2:48 ` [Qemu-devel] [PATCH 14/26] tcg-aarch64: Implement tcg_register_jit Richard Henderson
2014-03-15 2:48 ` [Qemu-devel] [PATCH 15/26] tcg-aarch64: Avoid add with zero in tlb load Richard Henderson
2014-03-26 9:36 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 16/26] tcg-aarch64: Use tcg_out_call for qemu_ld/st Richard Henderson
2014-03-26 9:37 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 17/26] tcg-aarch64: Use ADR to pass the return address to the ld/st helpers Richard Henderson
2014-03-26 9:38 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 18/26] tcg-aarch64: Use TCGMemOp in qemu_ld/st Richard Henderson
2014-03-26 9:39 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 19/26] tcg-aarch64: Implement TCG_TARGET_HAS_new_ldst Richard Henderson
2014-03-26 9:40 ` Claudio Fontana [this message]
2014-03-15 2:48 ` [Qemu-devel] [PATCH 20/26] tcg-aarch64: Introduce tcg_out_insn_3507 Richard Henderson
2014-03-26 9:40 ` Claudio Fontana
2014-03-15 2:48 ` [Qemu-devel] [PATCH 21/26] tcg-aarch64: Merge aarch64_ldst_get_data/type into tcg_out_op Richard Henderson
2014-03-15 2:48 ` [Qemu-devel] [PATCH 22/26] tcg-aarch64: Replace aarch64_ldst_op_data with TCGMemOp Richard Henderson
2014-03-15 2:48 ` [Qemu-devel] [PATCH 23/26] tcg-aarch64: Replace aarch64_ldst_op_data with AArch64LdstType Richard Henderson
2014-03-15 2:48 ` [Qemu-devel] [PATCH 24/26] tcg-aarch64: Prefer unsigned offsets before signed offsets for ldst Richard Henderson
2014-03-15 2:48 ` [Qemu-devel] [PATCH 25/26] tcg-aarch64: Merge tcg_out_movr with tcg_out_mov Richard Henderson
2014-03-15 2:48 ` [Qemu-devel] [PATCH 26/26] tcg-aarch64: Support stores of zero Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5332A07C.2030304@huawei.com \
--to=claudio.fontana@huawei.com \
--cc=claudio.fontana@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).