From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46977)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cov@codeaurora.org>) id 1WSq53-0003K2-4T
	for qemu-devel@nongnu.org; Wed, 26 Mar 2014 11:49:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cov@codeaurora.org>) id 1WSq4x-0003wF-9d
	for qemu-devel@nongnu.org; Wed, 26 Mar 2014 11:49:29 -0400
Received: from smtp.codeaurora.org ([198.145.11.231]:43123)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cov@codeaurora.org>) id 1WSq4x-0003w1-3f
	for qemu-devel@nongnu.org; Wed, 26 Mar 2014 11:49:23 -0400
Message-ID: <5332F6FD.6050200@codeaurora.org>
Date: Wed, 26 Mar 2014 11:49:17 -0400
From: Christopher Covington <cov@codeaurora.org>
MIME-Version: 1.0
References: <1395844634-11729-1-git-send-email-alex.bennee@linaro.org>
	<1395844634-11729-4-git-send-email-alex.bennee@linaro.org>
In-Reply-To: <1395844634-11729-4-git-send-email-alex.bennee@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH 3/4] qemu-log: new option -dfilter to
 limit output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: alex.bennee@linaro.org
Cc: Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Michael Walle <michael@walle.cc>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

Hi Alex,

Neat series.

On 03/26/2014 10:37 AM, alex.bennee@linaro.org wrote:
> From: Alex Benn=C3=A9e <alex.bennee@linaro.org>
>=20
> When debugging big programs or system emulation sometimes you want both
> the verbosity of cpu,exec et all but don't want to generate lots of log=
s
> for unneeded stuff. This patch adds a new option -dfilter which allows
> you to specify interesting address ranges in the form:
>=20
>   -dfilter 0x8000-0x9000,0xffffffc000080000+0x200,...
>=20
> Then logging code can use the new qemu_log_in_addr_range() function to
> decide if it will output logging information for the given range.
>=20

> diff --git a/qemu-options.hx b/qemu-options.hx
> index ee5437b..a5cd095 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2667,6 +2667,15 @@ STEXI
>  Output log in @var{logfile} instead of to stderr
>  ETEXI
> =20
> +DEF("dfilter", HAS_ARG, QEMU_OPTION_DFILTER, \
> +    "-dfilter range,..  filter debug output to range of addresses (use=
ful for -d cpu,exec,etc..)\n",
> +    QEMU_ARCH_ALL)

It might be helpful to include a quick note in the documentation about th=
e
format of range (based on your commit message and the code, I take it tha=
t
"a-b" means <a to b> while "a+b" means <a to a+b>).

Thanks,
Christopher

--=20
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.