From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSrGD-0003BJ-Pg for qemu-devel@nongnu.org; Wed, 26 Mar 2014 13:05:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSrG5-0006iG-11 for qemu-devel@nongnu.org; Wed, 26 Mar 2014 13:05:05 -0400 Received: from mail-qc0-x22b.google.com ([2607:f8b0:400d:c01::22b]:41574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSrG4-0006i9-Sf for qemu-devel@nongnu.org; Wed, 26 Mar 2014 13:04:56 -0400 Received: by mail-qc0-f171.google.com with SMTP id c9so2970075qcz.30 for ; Wed, 26 Mar 2014 10:04:56 -0700 (PDT) Sender: Richard Henderson Message-ID: <533308B4.5090104@twiddle.net> Date: Wed, 26 Mar 2014 10:04:52 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1393959667-19125-1-git-send-email-rth@twiddle.net> <20140306221025.GQ16760@hall.aurel32.net> In-Reply-To: <20140306221025.GQ16760@hall.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 0/8] tcg-ia64 ldst updates List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, aliguori@amazon.com On 03/06/2014 02:10 PM, Aurelien Jarno wrote: > On Tue, Mar 04, 2014 at 11:00:59AM -0800, Richard Henderson wrote: >> This is a revival of a patch set I submitted back in September. > > Well the patch set from September was much different and was followed by > a new version in October to which I answered, and even acked a few > patches. Indeed, all the patches you acked got applied back then. >> I've just re-tested it and things still look ok, so I'm just going >> to ask for a pull rather than pretending there might be review. > > Anyway this new version still doesn't work for 64-bit big endian guest, > so this is a NACK. This can be easily tested with for example a MIPS64 > guest using these images: http://people.debian.org/~aurel32/qemu/mips/ Thanks for the pointer. There was indeed a problem with bswap'ed signed loads. I'll repost sometime today, but only change aside from rebase is int shift = 64 - (8 << s_bits); - bswap2 = tcg_opc_i11(TCG_REG_P6, OPC_EXTR_U_I11, - TCG_REG_R8, TCG_REG_R8, shift, 63 - shift); + bswap2 = (opc & MO_SIGN ? OPC_EXTR_I11 : OPC_EXTR_U_I11); + bswap2 = tcg_opc_i11(TCG_REG_P6, bswap2, + TCG_REG_R8, TCG_REG_R8, shift, 63 - shift); r~