From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WStjn-0001RS-Tt for qemu-devel@nongnu.org; Wed, 26 Mar 2014 15:43:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WStjh-0002ND-U5 for qemu-devel@nongnu.org; Wed, 26 Mar 2014 15:43:47 -0400 Message-ID: <53332DE8.5060008@redhat.com> Date: Wed, 26 Mar 2014 20:43:36 +0100 From: Max Reitz MIME-Version: 1.0 References: <1395835569-21193-1-git-send-email-stefanha@redhat.com> <1395835569-21193-6-git-send-email-stefanha@redhat.com> In-Reply-To: <1395835569-21193-6-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0 05/47] block/cloop: refuse images with huge offsets arrays (CVE-2014-0144) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , pmatouse@redhat.com, qemu-stable@nongnu.org On 26.03.2014 13:05, Stefan Hajnoczi wrote: > Limit offsets_size to 512 MB so that: > > 1. g_malloc() does not abort due to an unreasonable size argument. > > 2. offsets_size does not overflow the bdrv_pread() int size argument. > > This limit imposes a maximum image size of 16 TB at 256 KB block size. > > Signed-off-by: Stefan Hajnoczi > Signed-off-by: Kevin Wolf > --- > block/cloop.c | 9 +++++++++ > tests/qemu-iotests/075 | 6 ++++++ > tests/qemu-iotests/075.out | 4 ++++ > 3 files changed, 19 insertions(+) Reviewed-by: Max Reitz