From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSuPk-0002G2-4b for qemu-devel@nongnu.org; Wed, 26 Mar 2014 16:27:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSuPe-0008SV-6t for qemu-devel@nongnu.org; Wed, 26 Mar 2014 16:27:08 -0400 Message-ID: <53333810.2060807@redhat.com> Date: Wed, 26 Mar 2014 21:26:56 +0100 From: Max Reitz MIME-Version: 1.0 References: <1395835569-21193-1-git-send-email-stefanha@redhat.com> <1395835569-21193-18-git-send-email-stefanha@redhat.com> In-Reply-To: <1395835569-21193-18-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0 17/47] vhdx: Bounds checking for block_size and logical_sector_size (CVE-2014-0148) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , pmatouse@redhat.com, qemu-stable@nongnu.org On 26.03.2014 13:05, Stefan Hajnoczi wrote: > From: Jeff Cody > > Other variables (e.g. sectors_per_block) are calculated using these > variables, and if not range-checked illegal values could be obtained > causing infinite loops and other potential issues when calculating > BAT entries. > > The 1.00 VHDX spec requires BlockSize to be min 1MB, max 256MB. > LogicalSectorSize is required to be either 512 or 4096 bytes. > > Reported-by: Kevin Wolf > Signed-off-by: Jeff Cody > Signed-off-by: Kevin Wolf > --- > block/vhdx.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz