From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSumv-0007wT-S1 for qemu-devel@nongnu.org; Wed, 26 Mar 2014 16:51:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSump-0007rR-T9 for qemu-devel@nongnu.org; Wed, 26 Mar 2014 16:51:05 -0400 Message-ID: <53333DAA.3040908@redhat.com> Date: Wed, 26 Mar 2014 21:50:50 +0100 From: Max Reitz MIME-Version: 1.0 References: <1395835569-21193-1-git-send-email-stefanha@redhat.com> <1395835569-21193-22-git-send-email-stefanha@redhat.com> In-Reply-To: <1395835569-21193-22-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0 21/47] qcow2: Check refcount table size (CVE-2014-0144) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , pmatouse@redhat.com, qemu-stable@nongnu.org On 26.03.2014 13:05, Stefan Hajnoczi wrote: > From: Kevin Wolf > > Limit the in-memory reference count table size to 8 MB, it's enough in > practice. This fixes an unbounded allocation as well as a buffer > overflow in qcow2_refcount_init(). > > Signed-off-by: Kevin Wolf > --- > block/qcow2-refcount.c | 4 +++- > block/qcow2.c | 9 +++++++++ > tests/qemu-iotests/080 | 10 ++++++++++ > tests/qemu-iotests/080.out | 7 +++++++ > 4 files changed, 29 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz