From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSyw4-0000Tz-L8 for qemu-devel@nongnu.org; Wed, 26 Mar 2014 21:16:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSyvq-0003Ps-LZ for qemu-devel@nongnu.org; Wed, 26 Mar 2014 21:16:48 -0400 Received: from mail-pd0-x232.google.com ([2607:f8b0:400e:c02::232]:40415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSyvq-0003PE-F9 for qemu-devel@nongnu.org; Wed, 26 Mar 2014 21:16:34 -0400 Received: by mail-pd0-f178.google.com with SMTP id x10so2618233pdj.23 for ; Wed, 26 Mar 2014 18:16:33 -0700 (PDT) Message-ID: <53337BEB.90305@gmail.com> Date: Thu, 27 Mar 2014 09:16:27 +0800 From: Chen Gang MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@amazon.com, QEMU Developers At present, each 'opt_name' of 'accel_list' is uniq with each other, so 'buf' can only match one 'opt_name'. When drop into the matching code block, can 'break' outside related 'for' looping after finish processing it (just like the other 'break' within the matching block). After print "... not support for this target", it can avoid to print "... accelerator does not exist". Signed-off-by: Chen Gang --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 842e897..b4f98fa 100644 --- a/vl.c +++ b/vl.c @@ -2709,7 +2709,7 @@ static int configure_accelerator(QEMUMachine *machine) if (!accel_list[i].available()) { printf("%s not supported for this target\n", accel_list[i].name); - continue; + break; } *(accel_list[i].allowed) = true; ret = accel_list[i].init(machine); -- 1.7.9.5