From: Wenchao Xia <wenchaoqemu@gmail.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>,
"Markus Armbruster" <armbru@redhat.com>
Cc: mreitz@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py
Date: Thu, 27 Mar 2014 15:52:26 +0800 [thread overview]
Message-ID: <5333D8BA.8070505@gmail.com> (raw)
In-Reply-To: <20140326131300.GA3860@irqsave.net>
>>>>>> You may need to rebase this on top of other patches that refactor the
>>>>>> qapi generators to track the input file, for improved error messages.
>>>>> It seems qapi-visit.py and qapi-types.py remains the same as above in
>>>>> upstream, which kind of change are your referring to?
>>>> Lluís' patch to use an explicit input file via a new -i option:
>>>> https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg05220.html
>>>>
>>> I see, will adjust it.
>>
>> Part of "[PATCH v4 0/3] qapi: Allow modularization of QAPI schema
>> files". There's also Benoît's "[PATCH 0/2] Create and include directive
>> for QAPI JSON files"[*]. Benoît, care to explain how the two are
>> related?
>
> I don't see the relation excepted that my patch changes the various qapi-generators
> to accept their input files as argv[1].
>
> The purpose of my patch is to implement a directive to modularise the pseudo JSON
> files we use. Lluis told me that he would not have the time to work on his series
> until the end of the month so I picked up the ball.
>
> Best regards
>
> Benoît
>
Thanks for the explain, I'll rebase on top once your series merged
into Luiz's tree.
>>
>> Wenchao, please note "you *may* need to rebase". First patch in wins :)
>>
>> [*] https://lists.nongnu.org/archive/html/qemu-devel/2014-03/msg04412.html
next prev parent reply other threads:[~2014-03-27 7:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 23:10 [Qemu-devel] [RFC PATCH V2 0/5] add direct support of event in qapi schema Wenchao Xia
2014-01-02 23:10 ` [Qemu-devel] [RFC PATCH V2 1/5] os-posix: include sys/time.h Wenchao Xia
2014-01-02 23:10 ` [Qemu-devel] [RFC PATCH V2 2/5] qapi: add event helper functions Wenchao Xia
2014-01-06 22:23 ` Luiz Capitulino
2014-01-07 2:28 ` Wenchao Xia
2014-03-06 18:26 ` Eric Blake
2014-01-02 23:10 ` [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py Wenchao Xia
2014-01-06 23:10 ` Luiz Capitulino
2014-01-06 23:17 ` Luiz Capitulino
2014-01-07 3:24 ` Wenchao Xia
2014-02-14 3:26 ` Wenchao Xia
2014-01-07 2:53 ` Wenchao Xia
2014-03-06 18:49 ` Eric Blake
2014-03-19 2:38 ` Wenchao Xia
2014-03-20 22:29 ` Eric Blake
2014-03-24 0:55 ` Wenchao Xia
2014-03-26 12:42 ` Markus Armbruster
2014-03-26 13:13 ` Benoît Canet
2014-03-27 7:52 ` Wenchao Xia [this message]
2014-01-02 23:10 ` [Qemu-devel] [RFC PATCH V2 4/5] test: add test cases for qapi event Wenchao Xia
2014-03-06 20:05 ` Eric Blake
2014-01-02 23:10 ` [Qemu-devel] [RFC PATCH V2 5/5] qapi event: convert RTC_CHANGE Wenchao Xia
2014-03-06 20:24 ` Eric Blake
2014-01-06 23:18 ` [Qemu-devel] [RFC PATCH V2 0/5] add direct support of event in qapi schema Luiz Capitulino
2014-03-06 18:14 ` Eric Blake
2014-03-06 19:58 ` Luiz Capitulino
2014-03-07 1:13 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5333D8BA.8070505@gmail.com \
--to=wenchaoqemu@gmail.com \
--cc=armbru@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=lcapitulino@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).