From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT57M-0005DV-Cl for qemu-devel@nongnu.org; Thu, 27 Mar 2014 03:52:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WT57E-0007H8-Rw for qemu-devel@nongnu.org; Thu, 27 Mar 2014 03:52:52 -0400 Received: from mail-pb0-x22b.google.com ([2607:f8b0:400e:c01::22b]:57675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT57E-0007FY-Lf for qemu-devel@nongnu.org; Thu, 27 Mar 2014 03:52:44 -0400 Received: by mail-pb0-f43.google.com with SMTP id um1so3105395pbc.2 for ; Thu, 27 Mar 2014 00:52:43 -0700 (PDT) Message-ID: <5333D8BA.8070505@gmail.com> Date: Thu, 27 Mar 2014 15:52:26 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1388704234-22498-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1388704234-22498-4-git-send-email-xiawenc@linux.vnet.ibm.com> <5318C354.6060706@redhat.com> <5329030F.5010401@gmail.com> <532B6BDE.9040705@redhat.com> <532F829E.8040903@gmail.com> <87zjkd5dxd.fsf@blackfin.pond.sub.org> <20140326131300.GA3860@irqsave.net> In-Reply-To: <20140326131300.GA3860@irqsave.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Markus Armbruster Cc: mreitz@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com >>>>>> You may need to rebase this on top of other patches that refactor the >>>>>> qapi generators to track the input file, for improved error messages. >>>>> It seems qapi-visit.py and qapi-types.py remains the same as above in >>>>> upstream, which kind of change are your referring to? >>>> Lluís' patch to use an explicit input file via a new -i option: >>>> https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg05220.html >>>> >>> I see, will adjust it. >> >> Part of "[PATCH v4 0/3] qapi: Allow modularization of QAPI schema >> files". There's also Benoît's "[PATCH 0/2] Create and include directive >> for QAPI JSON files"[*]. Benoît, care to explain how the two are >> related? > > I don't see the relation excepted that my patch changes the various qapi-generators > to accept their input files as argv[1]. > > The purpose of my patch is to implement a directive to modularise the pseudo JSON > files we use. Lluis told me that he would not have the time to work on his series > until the end of the month so I picked up the ball. > > Best regards > > Benoît > Thanks for the explain, I'll rebase on top once your series merged into Luiz's tree. >> >> Wenchao, please note "you *may* need to rebase". First patch in wins :) >> >> [*] https://lists.nongnu.org/archive/html/qemu-devel/2014-03/msg04412.html