From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT71p-0007rv-Qj for qemu-devel@nongnu.org; Thu, 27 Mar 2014 05:55:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WT71f-0000cE-Uk for qemu-devel@nongnu.org; Thu, 27 Mar 2014 05:55:17 -0400 Received: from mail-pb0-x230.google.com ([2607:f8b0:400e:c01::230]:49839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT71f-0000bc-Of for qemu-devel@nongnu.org; Thu, 27 Mar 2014 05:55:07 -0400 Received: by mail-pb0-f48.google.com with SMTP id md12so3228603pbc.7 for ; Thu, 27 Mar 2014 02:55:06 -0700 (PDT) Message-ID: <5333F570.6080205@gmail.com> Date: Thu, 27 Mar 2014 17:54:56 +0800 From: Chen Gang MIME-Version: 1.0 References: <53337BEB.90305@gmail.com> <1395906947.313.10.camel@localhost.localdomain> In-Reply-To: <1395906947.313.10.camel@localhost.localdomain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcel.a@redhat.com Cc: QEMU Developers , aliguori@amazon.com On 03/27/2014 03:55 PM, Marcel Apfelbaum wrote: > On Thu, 2014-03-27 at 09:16 +0800, Chen Gang wrote: >> At present, each 'opt_name' of 'accel_list' is uniq with each other, so >> 'buf' can only match one 'opt_name'. >> >> When drop into the matching code block, can 'break' outside related >> 'for' looping after finish processing it (just like the other 'break' >> within the matching block). >> >> After print "... not support for this target", it can avoid to print >> "... accelerator does not exist". > Hi, > Thanks for the patch! > > I would re-write > 1. The commit subject to: > Fix wrong warning on configure_accelerator > 2. The commit message to: > No need to continue to iterate over the accelerators list > after a match is found, even if it is not supported. > OK, thank you for your work (re-write it before commit it). Next I will/should notice about it. :-) >> >> >> Signed-off-by: Chen Gang >> --- >> vl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/vl.c b/vl.c >> index 842e897..b4f98fa 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -2709,7 +2709,7 @@ static int configure_accelerator(QEMUMachine *machine) >> if (!accel_list[i].available()) { >> printf("%s not supported for this target\n", >> accel_list[i].name); >> - continue; >> + break; > Seems like the right thing to do. > > Thanks, > Marcel > >> } >> *(accel_list[i].allowed) = true; >> ret = accel_list[i].init(machine); > > > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed