From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT77m-0005ZL-3H for qemu-devel@nongnu.org; Thu, 27 Mar 2014 06:01:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WT77d-0002q1-IM for qemu-devel@nongnu.org; Thu, 27 Mar 2014 06:01:26 -0400 Received: from mail-pd0-x22e.google.com ([2607:f8b0:400e:c02::22e]:37285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT77d-0002pw-Bi for qemu-devel@nongnu.org; Thu, 27 Mar 2014 06:01:17 -0400 Received: by mail-pd0-f174.google.com with SMTP id y13so3147421pdi.33 for ; Thu, 27 Mar 2014 03:01:16 -0700 (PDT) Message-ID: <5333F6E2.9080202@gmail.com> Date: Thu, 27 Mar 2014 18:01:06 +0800 From: Chen Gang MIME-Version: 1.0 References: <53337BEB.90305@gmail.com> <87wqfgrp83.fsf@blackfin.pond.sub.org> In-Reply-To: <87wqfgrp83.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: QEMU Developers , aliguori@amazon.com On 03/27/2014 04:59 PM, Markus Armbruster wrote: > Chen Gang writes: > >> At present, each 'opt_name' of 'accel_list' is uniq with each other, so >> 'buf' can only match one 'opt_name'. >> >> When drop into the matching code block, can 'break' outside related >> 'for' looping after finish processing it (just like the other 'break' >> within the matching block). >> >> After print "... not support for this target", it can avoid to print >> "... accelerator does not exist". >> >> >> Signed-off-by: Chen Gang >> --- >> vl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/vl.c b/vl.c >> index 842e897..b4f98fa 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -2709,7 +2709,7 @@ static int configure_accelerator(QEMUMachine *machine) >> if (!accel_list[i].available()) { >> printf("%s not supported for this target\n", >> accel_list[i].name); >> - continue; >> + break; >> } >> *(accel_list[i].allowed) = true; >> ret = accel_list[i].init(machine); > > Works, because the opt_name in accel_list[] are distinct, as you > explained in your commit message. > > Apropos commit message. You first explain what you do, and only then > state the problem you're trying to solve. That's backwards. Start with > the problem. Only then explain your solution, if it needs explaining. > This one, I think, doesn't. > > Suggested commit message: > > vl: Report accelerator not supported for target more nicely > > When you ask for an accelerator not supported for your target, you > get a bogus "accelerator does not exist" message: > > $ qemu-system-arm -machine none,accel=kvm > KVM not supported for this target > "kvm" accelerator does not exist. > No accelerator found! > > Suppress it. > Thank you for your details, that sounds reasonable to me. Next, I will/should notice start with the issue, and then explain the solution. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed