From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>, Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/2] tests: skip POSIX-only tests on Windows
Date: Thu, 27 Mar 2014 12:53:49 +0100 [thread overview]
Message-ID: <5334114D.2040001@redhat.com> (raw)
In-Reply-To: <1395918686-27043-2-git-send-email-stefanha@redhat.com>
Il 27/03/2014 12:11, Stefan Hajnoczi ha scritto:
> test-aio, test-rfifolock, and test-vmstate only build on POSIX hosts.
test-aio should build on Win32. Can be fixed in 2.1 though.
Paolo
> Exclude them if building for Windows.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> tests/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 2d021fb..803c8e6 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -34,8 +34,8 @@ gcov-files-test-coroutine-y = coroutine-$(CONFIG_COROUTINE_BACKEND).c
> check-unit-y += tests/test-visitor-serialization$(EXESUF)
> check-unit-y += tests/test-iov$(EXESUF)
> gcov-files-test-iov-y = util/iov.c
> -check-unit-y += tests/test-aio$(EXESUF)
> -check-unit-y += tests/test-rfifolock$(EXESUF)
> +check-unit-$(CONFIG_POSIX) += tests/test-aio$(EXESUF)
> +check-unit-$(CONFIG_POSIX) += tests/test-rfifolock$(EXESUF)
> check-unit-y += tests/test-throttle$(EXESUF)
> gcov-files-test-aio-$(CONFIG_WIN32) = aio-win32.c
> gcov-files-test-aio-$(CONFIG_POSIX) = aio-posix.c
> @@ -59,7 +59,7 @@ check-unit-y += tests/test-bitops$(EXESUF)
> check-unit-y += tests/test-qdev-global-props$(EXESUF)
> check-unit-y += tests/check-qom-interface$(EXESUF)
> gcov-files-check-qom-interface-y = qom/object.c
> -check-unit-y += tests/test-vmstate$(EXESUF)
> +check-unit-$(CONFIG_POSIX) += tests/test-vmstate$(EXESUF)
>
> check-block-$(CONFIG_POSIX) += tests/qemu-iotests-quick.sh
>
>
next prev parent reply other threads:[~2014-03-27 11:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 11:11 [Qemu-devel] [PATCH 0/2] tests: mingw32 make check fixes Stefan Hajnoczi
2014-03-27 11:11 ` [Qemu-devel] [PATCH 1/2] tests: skip POSIX-only tests on Windows Stefan Hajnoczi
2014-03-27 11:53 ` Paolo Bonzini [this message]
2014-03-27 14:01 ` Stefan Hajnoczi
2014-03-27 14:07 ` Andreas Färber
2014-03-27 21:21 ` Stefan Weil
2014-03-27 11:11 ` [Qemu-devel] [PATCH 2/2] tests: correctly skip qtest on non-POSIX hosts Stefan Hajnoczi
2014-03-27 12:22 ` Andreas Färber
2014-03-27 11:14 ` [Qemu-devel] [PATCH 0/2] tests: mingw32 make check fixes Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5334114D.2040001@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).