From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTA6u-0007oF-QO for qemu-devel@nongnu.org; Thu, 27 Mar 2014 09:12:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTA6q-0003C6-L9 for qemu-devel@nongnu.org; Thu, 27 Mar 2014 09:12:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60549) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTA6q-0003An-CD for qemu-devel@nongnu.org; Thu, 27 Mar 2014 09:12:40 -0400 Message-ID: <533423C0.5090409@redhat.com> Date: Thu, 27 Mar 2014 07:12:32 -0600 From: Eric Blake MIME-Version: 1.0 References: <1395832121-858851-1-git-send-email-anton.ivanov@kot-begemot.co.uk> In-Reply-To: <1395832121-858851-1-git-send-email-anton.ivanov@kot-begemot.co.uk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ncm8RPS5T49LRIRQL59rpI9evDKIOU0gO" Subject: Re: [Qemu-devel] [PATCH v6] net: L2TPv3 transport List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anton.ivanov@kot-begemot.co.uk, qemu-devel@nongnu.org Cc: Anton Ivanov , pbonzini@redhat.com, afaerber@suse.de, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ncm8RPS5T49LRIRQL59rpI9evDKIOU0gO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/26/2014 05:08 AM, anton.ivanov@kot-begemot.co.uk wrote: > From: Anton Ivanov >=20 > This transport allows to connect a QEMU nic to a static Ethernet > over L2TPv3 tunnel. The transport supports all options present > in the Linux kernel implementation. It allows QEMU to connect > to any Linux host running kernel 3.3+, most routers and network > devices as well as other QEMU instances. >=20 > Signed-off-by: Anton Ivanov > --- > # > # Since 1.2 > -## > +# > +# Added in 2.1 - l2tpv3 > +# > { 'union': 'NetClientOptions', Minor nit - you lost the ## end-of-comment line. Also, see how QKeyCode mentioned added values: # Since: 1.3.0 # # 'unmapped' and 'pause' since 2.0 ## We haven't done this sort of addition much to date, but it can't hurt to use a consistent style when doing so. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ncm8RPS5T49LRIRQL59rpI9evDKIOU0gO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTNCPAAAoJEKeha0olJ0NqqP8H/RWIci42y0SMp/fBR0Te3Td0 JpACuD+lfMykWWRA35++66q5x9SSEM1fep1Ie14+NAot0c3jGOqMzzugwJbemRGl Rv2ylfQOo3W/DgZbfATxJqvjvDO9ctgNJm/BXtdJFX/ZSxx0Rjs1rbGoVq/fMIcp LDvm8iIz+C0f9zpvBx5EHFaafJJV3OJof9nUdv0s2RuZx97yM83qdzbGfYusPBqa hTk3PivOMGyc4iKtfkX6Gi33ZAz7+Vg+QPYrveG/l01huBaxUe54JPrAbyw0TIb8 jcIUBMY+IgwprF7UHksl0BDbSDhuHezc0afthhzPEio+9JKHQGnReAQddBGqBek= =Zbtb -----END PGP SIGNATURE----- --Ncm8RPS5T49LRIRQL59rpI9evDKIOU0gO--