From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43975)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cov@codeaurora.org>) id 1WTB4l-0008Sh-Uw
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 10:14:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cov@codeaurora.org>) id 1WTB4f-0000ZK-6x
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 10:14:35 -0400
Received: from smtp.codeaurora.org ([198.145.11.231]:55963)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cov@codeaurora.org>) id 1WTB4f-0000ZE-15
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 10:14:29 -0400
Message-ID: <53343241.1080502@codeaurora.org>
Date: Thu, 27 Mar 2014 10:14:25 -0400
From: Christopher Covington <cov@codeaurora.org>
MIME-Version: 1.0
References: <1395844634-11729-1-git-send-email-alex.bennee@linaro.org>
	<1395844634-11729-4-git-send-email-alex.bennee@linaro.org>
	<5332F6FD.6050200@codeaurora.org> <87r45nvpbk.fsf@linaro.org>
In-Reply-To: <87r45nvpbk.fsf@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH 3/4] qemu-log: new option -dfilter to
 limit output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>
Cc: Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Michael Walle <michael@walle.cc>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

Hi Alex,

On 03/27/2014 07:44 AM, Alex Benn=C3=A9e wrote:
>=20
> Christopher Covington <cov@codeaurora.org> writes:
>=20
>> Hi Alex,
>>
> <snip>
>=20
> DEF("dfilter", HAS_ARG, QEMU_OPTION_DFILTER, \
>     "-dfilter range,..  filter debug output to range of addresses (usef=
ul for -d cpu,exec,etc..)\n",
>     QEMU_ARCH_ALL)
> STEXI
> @item -dfilter @var{range1}[,...]
> @findex -dfilter
> Filter debug output to that relevant to a range of target addresses. Th=
e filter
> spec can be either 0x${START}-0x${END} or 0x${START}+0x${OFF} where ${S=
TART}
> ${END} and ${OFF} are the addresses and sizes required. For example:
>=20
>     -dfilter 0x8000-0x9000,0xffffffc000080000+0x200
>=20
> Will dump output for any code in the 0x1000 sized block starting at 0x8=
000 and
> the 0x200 sized block starting at 0xffffffc000080000.
> ETEXI
>=20
> Does that read clearly enough? I assume that should magically make it's
> way to the man page somehow?

This level of detail is helpful. I think "range1" and "filter spec" shoul=
d use
matching terms. Unless space is at a premium, spelling out ${OFFSET} migh=
t aid
some readers.

In the C portion, I wonder if renaming qemu_log_in_addr_range to somethin=
g
like qemu_addr_in_dfilter_ranges might add clarity?

Christopher

--=20
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.