From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56547)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WTBl2-0004NP-JV
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 10:58:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WTBkw-0000Hv-L7
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 10:58:16 -0400
Message-ID: <53343C80.5060708@suse.de>
Date: Thu, 27 Mar 2014 15:58:08 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1395715231-4217-1-git-send-email-anton@samba.org>
	<871txqspmq.fsf@linaro.org>
In-Reply-To: <871txqspmq.fsf@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/6] target-ppc: POWER8 supports the MSR_LE
 bit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, Anton Blanchard <anton@samba.org>
Cc: clg@fr.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, gkurz@linux.vnet.ibm.com

Am 25.03.2014 08:29, schrieb Alex Benn=C3=A9e:
>=20
> Anton Blanchard <anton@samba.org> writes:
>=20
>> Add MSR_LE to the msr_mask for POWER8.
>>
> <snip>
>> -    pcc->msr_mask =3D 0x800000000284FF36ULL;
>> +    pcc->msr_mask =3D 0x800000000284FF37ULL;
> <snip>
>=20
> Should we be adding some #define's for the various bit positions on thi=
s
> mask? Looking at the current code it looks like a big ream of magic
> numbers.

In general I concur that defines would be nice, however for 2.0 that's
too risky for me as temporary maintainer and I'm not sure if these
values are being pieced together by contributors or whether this is
coming directly from the manual?

The other issue has been that adding a new family, even after the
initial round of cleanups, still requires a chunk of code to be copied,
which seems prone to forgetting little bits on the new one, then maybe
fixing up the original template but not the derived models, etc.

Cheers,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg