From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTDV1-00023H-D6 for qemu-devel@nongnu.org; Thu, 27 Mar 2014 12:49:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTDUw-0006vf-Hl for qemu-devel@nongnu.org; Thu, 27 Mar 2014 12:49:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTDUw-0006vP-47 for qemu-devel@nongnu.org; Thu, 27 Mar 2014 12:49:46 -0400 Message-ID: <533456A5.3080106@redhat.com> Date: Thu, 27 Mar 2014 10:49:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1395911388-31027-1-git-send-email-famz@redhat.com> <1395911388-31027-10-git-send-email-famz@redhat.com> In-Reply-To: <1395911388-31027-10-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UarnN1hrpcodvh7KPisvkJxoaDS1opwG2" Subject: Re: [Qemu-devel] [PATCH v4 9/9] qapi: Add transaction support to dirty-bitmap-{add, disable} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Benoit Canet , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UarnN1hrpcodvh7KPisvkJxoaDS1opwG2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/27/2014 03:09 AM, Fam Zheng wrote: > This adds dirty-bitmap-add and dirty-bitmap-disable to transactions. > With this, user can stop a dirty bitmap, start backup of it, and start > another dirty bitmap atomically, so that the dirty bitmap is tracked > incrementally and we don't miss any write. Ah, this addresses my question in 7/9 about atomicity of creating a map in disabled state. Nice idea to use 'transaction' to merge the two commands, instead of having to bloat the creation with ever more options.= >=20 > Signed-off-by: Fam Zheng > --- > blockdev.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > qapi-schema.json | 4 +++- > 2 files changed, 71 insertions(+), 1 deletion(-) >=20 > +++ b/qapi-schema.json > @@ -1994,7 +1994,9 @@ > 'blockdev-snapshot-sync': 'BlockdevSnapshot', > 'drive-backup': 'DriveBackup', > 'abort': 'Abort', > - 'blockdev-snapshot-internal-sync': 'BlockdevSnapshotInternal' > + 'blockdev-snapshot-internal-sync': 'BlockdevSnapshotInternal', > + 'dirty-bitmap-add': 'DirtyBitmap', > + 'dirty-bitmap-disable': 'DirtyBitmap' > } } However, shouldn't it ALSO be possible to enable a bitmap in tandem with other transaction operations? I can imagine a transaction that both kicks off a snapshot and enables a bitmap that was previously added but left disabled. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UarnN1hrpcodvh7KPisvkJxoaDS1opwG2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTNFalAAoJEKeha0olJ0NqWIsH/1Y1DD8vp8K9dznT0I7/4pYQ zZDND5Sn9mNHb1w6qisDp/U9chyw2eIIn2nxeJscrj1eTmnBcJeUyQTlfB6VqVY1 mZT2f7em6DrlMHlGNz1kjgcbakt25JOmahoUS6pCJck5vNgeV8wJ4pmZtyMUum0J AjYv3ZegJ5j/pIaQIpC0eyfdRIo+STuNK5S+CWD8pqn72Z+1qPzLHvYuVnnjHWw6 O7grFN9+OU568cWV9INHfI6FZ5YnIbw7oKVBZvouDHuH860VOBUAUVdkbtrPw3Ic ewP7ctlRul/Q+ULAXikl8sY29t95I5Ipx8kWRqhuTQMz2KRXQaM2nLnHMaA7whk= =aWwr -----END PGP SIGNATURE----- --UarnN1hrpcodvh7KPisvkJxoaDS1opwG2--