Re: [Qemu-devel] [PATCH 16/16] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]

On 02/11/2014 06:08 AM, Samuel Thibault wrote:
> This patchs adds parameters to manage some new options in the qemu -net

s/patchs/patch/

> command.
> Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in
> argument to the qemu command.
> Defaults parameters are respectively fec0::2, fec0::, /64 and fec0::3.
> 
> Signed-off-by: Yann Bordenave <meow@meowstars.org>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
>  net/net.c        | 30 ++++++++++++++++++++++++++++++
>  net/slirp.c      | 46 ++++++++++++++++++++++++++++++++++++++++------
>  qapi-schema.json | 40 ++++++++++++++++++++++++++--------------
>  qemu-options.hx  | 18 ++++++++++++++++--
>  slirp/libslirp.h |  8 +++++---
>  slirp/slirp.c    | 20 +++++++++-----------
>  6 files changed, 126 insertions(+), 36 deletions(-)
> 

Just reviewing the QMP side:

> +++ b/qapi-schema.json
> @@ -2906,6 +2906,14 @@
>  # @dnssearch: #optional list of DNS suffixes to search, passed as DHCP option
>  #             to the guest
>  #
> +# @ip6-prefix: #optional IPv6 network prefix (since 1.8)

There was no 1.8 release, and you've missed the 2.0 release.  This, and
all other instances in the patch to this file, must be '(since 2.1)'

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]