From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTI4Z-0004VS-B0 for qemu-devel@nongnu.org; Thu, 27 Mar 2014 17:42:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTI4U-0006WH-Vc for qemu-devel@nongnu.org; Thu, 27 Mar 2014 17:42:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTI4U-0006W5-NO for qemu-devel@nongnu.org; Thu, 27 Mar 2014 17:42:46 -0400 Message-ID: <53349B4D.2070704@redhat.com> Date: Thu, 27 Mar 2014 15:42:37 -0600 From: Eric Blake MIME-Version: 1.0 References: <1384700688-30377-1-git-send-email-samuel.thibault@ens-lyon.org> <1392124097-10618-1-git-send-email-samuel.thibault@ens-lyon.org> <1392124097-10618-17-git-send-email-samuel.thibault@ens-lyon.org> In-Reply-To: <1392124097-10618-17-git-send-email-samuel.thibault@ens-lyon.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LqETxuQxg75MjbsFKeREBQJX2oHcf4tpo" Subject: Re: [Qemu-devel] [PATCH 16/16] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault , qemu-devel@nongnu.org Cc: Jan Kiszka , Yann Bordenave , Guillaume Subiron This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LqETxuQxg75MjbsFKeREBQJX2oHcf4tpo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/11/2014 06:08 AM, Samuel Thibault wrote: > This patchs adds parameters to manage some new options in the qemu -net= s/patchs/patch/ > command. > Slirp IPv6 address, network prefix, and DNS IPv6 address can be given i= n > argument to the qemu command. > Defaults parameters are respectively fec0::2, fec0::, /64 and fec0::3. >=20 > Signed-off-by: Yann Bordenave > Signed-off-by: Samuel Thibault > --- > net/net.c | 30 ++++++++++++++++++++++++++++++ > net/slirp.c | 46 ++++++++++++++++++++++++++++++++++++++++------ > qapi-schema.json | 40 ++++++++++++++++++++++++++-------------- > qemu-options.hx | 18 ++++++++++++++++-- > slirp/libslirp.h | 8 +++++--- > slirp/slirp.c | 20 +++++++++----------- > 6 files changed, 126 insertions(+), 36 deletions(-) >=20 Just reviewing the QMP side: > +++ b/qapi-schema.json > @@ -2906,6 +2906,14 @@ > # @dnssearch: #optional list of DNS suffixes to search, passed as DHCP= option > # to the guest > # > +# @ip6-prefix: #optional IPv6 network prefix (since 1.8) There was no 1.8 release, and you've missed the 2.0 release. This, and all other instances in the patch to this file, must be '(since 2.1)' --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LqETxuQxg75MjbsFKeREBQJX2oHcf4tpo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTNJtNAAoJEKeha0olJ0NqAfEH/Aodh9OUbULOLSb1EG5r5pwT kfIl66Tp/KwklaPI9ss8bnT7CAuKyjuLRtsNkTIalxT4pniT0jQV+YCbuZFPScTf DHeaccRHdyv6cMWFm4GTMngxhICDs9SgACc40jO+sli0nRf2X9EIuEI/gcUjfGPt U53N3myMW7f6avXHxIQ8V0ggVLSIYVQYpP7I3lMdoEQHQmXpXfJ559I5RdxO1EGd 35feTrvWyVZMeLz36JXwxiiMzX69AaHOXq1yz7WaRDJcBR8PLOTNOew8J61M7zpJ cUfvAY/jq8KaObmwAasA2Ni8jJbPeofvQHZ9J+JalBm4hMgdGD+PWzoeo7oaFDc= =TtOu -----END PGP SIGNATURE----- --LqETxuQxg75MjbsFKeREBQJX2oHcf4tpo--