From: "Andreas Färber" <afaerber@suse.de>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
thuth@linux.vnet.ibm.com, mst@redhat.com, marc.zyngier@arm.com,
rusty@rustcorp.com.au, agraf@suse.de, qemu-devel@nongnu.org,
stefanha@redhat.com, cornelia.huck@de.ibm.com,
pbonzini@redhat.com, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCH v6 6/8] virtio-scsi: use virtio wrappers to access headers
Date: Fri, 28 Mar 2014 18:21:43 +0100 [thread overview]
Message-ID: <5335AFA7.9010306@suse.de> (raw)
In-Reply-To: <20140328181326.22c0a6a5@bahia.local>
Am 28.03.2014 18:13, schrieb Greg Kurz:
> On Fri, 28 Mar 2014 11:57:56 +0100
> Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
>> @@ -519,8 +521,8 @@ static void virtio_scsi_push_event(VirtIOSCSI *s, SCSIDevice *dev,
>>
>> evt = req->resp.event;
>> memset(evt, 0, sizeof(VirtIOSCSIEvent));
>> - evt->event = event;
>> - evt->reason = reason;
>> + evt->event = virtio_tswap32(event);
>> + evt->reason = virtio_tswap32(reason);
>
> My bad again, it should be:
>
> + evt->event = virtio_tswap32(event, vdev);
> + evt->reason = virtio_tswap32(reason, vdev);
Pure bikeshedding, but wouldn't it make sense to have the vdev as first
argument?
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-03-28 17:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 10:57 [Qemu-devel] [PATCH v6 0/8] virtio endian-ambivalent target fixes Greg Kurz
2014-03-28 10:57 ` [Qemu-devel] [PATCH v6 1/8] virtio_legacy_get_byteswap: endian-ambivalent targets using legacy virtio Greg Kurz
2014-03-28 14:15 ` Thomas Huth
2014-03-28 15:40 ` Greg Kurz
2014-03-28 17:59 ` Andreas Färber
2014-03-28 19:00 ` Greg Kurz
2014-03-31 14:50 ` Alexander Graf
2014-04-01 11:54 ` Greg Kurz
2014-03-28 10:57 ` [Qemu-devel] [PATCH v6 2/8] virtio: allow byte swapping for vring and config access Greg Kurz
2014-03-28 16:07 ` Thomas Huth
2014-03-28 17:02 ` Greg Kurz
2014-03-31 16:24 ` Alexander Graf
2014-03-31 16:26 ` Andreas Färber
2014-04-01 12:03 ` Greg Kurz
2014-03-28 10:57 ` [Qemu-devel] [PATCH v6 3/8] virtio-net: use virtio wrappers to access headers Greg Kurz
2014-03-31 16:28 ` Alexander Graf
2014-03-28 10:57 ` [Qemu-devel] [PATCH v6 4/8] virtio-balloon: use virtio wrappers to access page frame numbers Greg Kurz
2014-03-31 16:30 ` Alexander Graf
2014-03-28 10:57 ` [Qemu-devel] [PATCH v6 5/8] virtio-blk: use virtio wrappers to access headers Greg Kurz
2014-03-31 16:31 ` Alexander Graf
2014-03-28 10:57 ` [Qemu-devel] [PATCH v6 6/8] virtio-scsi: " Greg Kurz
2014-03-28 17:13 ` Greg Kurz
2014-03-28 17:21 ` Andreas Färber [this message]
2014-03-28 17:37 ` Greg Kurz
2014-03-28 17:43 ` Peter Maydell
2014-03-28 18:04 ` Greg Kurz
2014-03-28 18:14 ` Peter Maydell
2014-03-28 18:58 ` Greg Kurz
2014-03-31 16:34 ` Alexander Graf
2014-03-28 10:58 ` [Qemu-devel] [PATCH v6 7/8] virtio-serial-bus: " Greg Kurz
2014-03-31 17:01 ` Alexander Graf
2014-03-28 10:58 ` [Qemu-devel] [PATCH v6 8/8] virtio-9p: " Greg Kurz
2014-03-28 11:22 ` [Qemu-devel] [PATCH v4] target-ppc: ppc64 target's virtio can be either endian Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5335AFA7.9010306@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=cornelia.huck@de.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=marc.zyngier@arm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=stefanha@redhat.com \
--cc=thuth@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).