From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [RFC 0/3] tcg: Avoid undefined behaviour on unaligned stores
Date: Fri, 28 Mar 2014 11:48:46 -0700 [thread overview]
Message-ID: <5335C40E.3010102@twiddle.net> (raw)
In-Reply-To: <CAFEAcA97Ek81unhKzJbabCz9K9dN1QaFxpJ7FC6tK78vCg6SqA@mail.gmail.com>
On 03/28/2014 11:18 AM, Peter Maydell wrote:
> On 28 March 2014 18:06, Richard Henderson <rth@twiddle.net> wrote:
>> On 03/28/2014 08:29 AM, Peter Maydell wrote:
>>> Peter Maydell (3):
>>> exec-all.h: Use stl_p to avoid undefined behaviour patching x86 jumps
>>> tcg: Avoid stores to unaligned addresses
>>> tcg: Avoid undefined behaviour patching code at unaligned addresses
>>
>> Reviewed-by: Richard Henderson <rth@twiddle.net>
>
> I was expecting more argument :-)
>
> I'll do a respin with separate tcg_out*_unaligned and tcg_out*,
> and update all the backends.
Please don't. I'd rather make different changes there, making s->code_ptr be
more appropriate to the elemental type of the native insn.
Since x86 wouldn't change its elemental type, I think your change is the best
of the possible solutions there.
r~
prev parent reply other threads:[~2014-03-28 18:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 15:29 [Qemu-devel] [RFC 0/3] tcg: Avoid undefined behaviour on unaligned stores Peter Maydell
2014-03-28 15:29 ` [Qemu-devel] [RFC 1/3] exec-all.h: Use stl_p to avoid undefined behaviour patching x86 jumps Peter Maydell
2014-03-28 15:29 ` [Qemu-devel] [RFC 2/3] tcg: Avoid stores to unaligned addresses Peter Maydell
2014-03-28 16:00 ` Andreas Färber
2014-03-28 15:29 ` [Qemu-devel] [RFC 3/3] tcg: Avoid undefined behaviour patching code at " Peter Maydell
2014-03-28 18:06 ` [Qemu-devel] [RFC 0/3] tcg: Avoid undefined behaviour on unaligned stores Richard Henderson
2014-03-28 18:18 ` Peter Maydell
2014-03-28 18:48 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5335C40E.3010102@twiddle.net \
--to=rth@twiddle.net \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).